Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2427)

Unified Diff: apps/moterm/moterm_view.cc

Issue 1975993002: Change InterfaceFactory<I>::Create() to take a ConnectionContext instead of an ApplicationConnectio… (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « apps/moterm/moterm_view.h ('k') | examples/apptest/example_service_application.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/moterm/moterm_view.cc
diff --git a/apps/moterm/moterm_view.cc b/apps/moterm/moterm_view.cc
index bf6fc462fb16daf576d2bdab8e2039f431b3ea2f..413d486001b92ae81190c87adb247a16f81d2b63 100644
--- a/apps/moterm/moterm_view.cc
+++ b/apps/moterm/moterm_view.cc
@@ -53,7 +53,11 @@ MotermView::MotermView(
// TODO(vtl): |service_provider_impl_|'s ctor doesn't like an invalid request,
// so we have to conditionally, explicitly bind.
if (service_provider_request.is_pending()) {
- service_provider_impl_.Bind(service_provider_request.Pass());
+ // TODO(vtl): The connection context should probably be plumbed here, which
+ // means that mojo::ui::ViewProviderApp::CreateView() should probably have a
+ // connection context argument.
+ service_provider_impl_.Bind(mojo::ConnectionContext(),
+ service_provider_request.Pass());
service_provider_impl_.AddService<mojo::terminal::Terminal>(this);
}
@@ -130,7 +134,7 @@ void MotermView::OnDestroyed() {
}
void MotermView::Create(
- mojo::ApplicationConnection* connection,
+ const mojo::ConnectionContext& connection_context,
mojo::InterfaceRequest<mojo::terminal::Terminal> request) {
terminal_bindings_.AddBinding(this, request.Pass());
}
« no previous file with comments | « apps/moterm/moterm_view.h ('k') | examples/apptest/example_service_application.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698