Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1975983002: Fix comment in fx_string.h (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix comment in fx_string.h Previous CLs have removed or marked explicit the constructors which allowed bad constructs to compile. I now get an error: candidate constructor not viable: expects an l-value for 1st argument when called as indicated in the comment. Committed: https://pdfium.googlesource.com/pdfium/+/ade9465067098d9f94a13f61741cebf4bb8aac47

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M core/fxcrt/include/fx_string.h View 2 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Lei, only the comment changed. Payoff from some of the "explict" work.
4 years, 7 months ago (2016-05-12 21:44:03 UTC) #2
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-12 22:09:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975983002/1
4 years, 7 months ago (2016-05-12 22:33:01 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 22:50:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/ade9465067098d9f94a13f61741cebf4bb8a...

Powered by Google App Engine
This is Rietveld 408576698