Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: components/page_load_metrics/browser/page_load_metrics_observer.h

Issue 1975963003: Improved and generalized page load metric immediate event logging. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/page_load_metrics/browser/metrics_web_contents_observer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/page_load_metrics/browser/page_load_metrics_observer.h
diff --git a/components/page_load_metrics/browser/page_load_metrics_observer.h b/components/page_load_metrics/browser/page_load_metrics_observer.h
index 6a2a2c6100c239b2389fa5f801c69837b4e84eca..b5e951f5cba965244f62b00df04e25c7acaaa9b6 100644
--- a/components/page_load_metrics/browser/page_load_metrics_observer.h
+++ b/components/page_load_metrics/browser/page_load_metrics_observer.h
@@ -142,6 +142,28 @@ class PageLoadMetricsObserver {
// After this call, the object will be deleted.
virtual void OnComplete(const PageLoadTiming& timing,
const PageLoadExtraInfo& extra_info) {}
+
+ // The following methods are invoked at most once, when the timing for the
+ // associated event first becomes available.
+ virtual void OnDomContentLoadedEventStart(
+ const PageLoadTiming& timing,
+ const PageLoadExtraInfo& extra_info) {}
+ virtual void OnLoadEventStart(const PageLoadTiming& timing,
+ const PageLoadExtraInfo& extra_info) {}
+ virtual void OnFirstLayout(const PageLoadTiming& timing,
+ const PageLoadExtraInfo& extra_info) {}
+ virtual void OnFirstPaint(const PageLoadTiming& timing,
+ const PageLoadExtraInfo& extra_info) {}
+ virtual void OnFirstTextPaint(const PageLoadTiming& timing,
+ const PageLoadExtraInfo& extra_info) {}
+ virtual void OnFirstImagePaint(const PageLoadTiming& timing,
+ const PageLoadExtraInfo& extra_info) {}
+ virtual void OnFirstContentfulPaint(const PageLoadTiming& timing,
+ const PageLoadExtraInfo& extra_info) {}
+ virtual void OnParseStart(const PageLoadTiming& timing,
+ const PageLoadExtraInfo& extra_info) {}
+ virtual void OnParseStop(const PageLoadTiming& timing,
+ const PageLoadExtraInfo& extra_info) {}
};
} // namespace page_load_metrics
« no previous file with comments | « components/page_load_metrics/browser/metrics_web_contents_observer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698