Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc

Issue 1975963003: Improved and generalized page load metric immediate event logging. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
index c15c30a5e78b7d7966b14b61492e7e18a707371e..2a47b7af8e0dbd71f8476d17e8a2dca74d35ef1f 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
@@ -132,17 +132,13 @@ CorePageLoadMetricsObserver::CorePageLoadMetricsObserver() {}
CorePageLoadMetricsObserver::~CorePageLoadMetricsObserver() {}
-void CorePageLoadMetricsObserver::OnTimingUpdate(
+void CorePageLoadMetricsObserver::OnFirstContentfulPaint(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
- if (!logged_first_contentful_paint_from_timing_update_ &&
- !timing.first_contentful_paint.is_zero()) {
- if (WasStartedInForegroundEventInForeground(timing.first_contentful_paint,
- info)) {
- PAGE_LOAD_HISTOGRAM(internal::kHistogramFirstContentfulPaintImmediate,
- timing.first_contentful_paint);
- }
- logged_first_contentful_paint_from_timing_update_ = true;
+ if (WasStartedInForegroundEventInForeground(timing.first_contentful_paint,
+ info)) {
+ PAGE_LOAD_HISTOGRAM(internal::kHistogramFirstContentfulPaintImmediate,
+ timing.first_contentful_paint);
}
}

Powered by Google App Engine
This is Rietveld 408576698