Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1975933002: cmake: fixes for windows (Closed)

Created:
4 years, 7 months ago by hal.canary
Modified:
4 years, 7 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org, corey.lucier, mtklein
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -12 lines) Patch
M cmake/CMakeLists.txt View 2 chunks +7 lines, -4 lines 0 comments Download
M cmake/README.md View 2 chunks +19 lines, -7 lines 0 comments Download
M cmake/example.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
hal.canary
PTAL
4 years, 7 months ago (2016-05-12 17:50:39 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975933002/1
4 years, 7 months ago (2016-05-12 17:57:35 UTC) #5
bungeman-skia
lgtm
4 years, 7 months ago (2016-05-12 18:08:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975933002/1
4 years, 7 months ago (2016-05-12 18:19:06 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 18:25:04 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dd4fcd450016648c1d8f298cea762e9b1308fbb5

Powered by Google App Engine
This is Rietveld 408576698