Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Issue 19759003: Replace BuildFastElementAccess() with AddFastElementAccess(). (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer
Modified:
7 years, 5 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Replace BuildFastElementAccess() with AddFastElementAccess(). This is trivial cleanup. All calls to BuildFastElementAccess() pass the result to AddInstruction(). R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15789

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -49 lines) Patch
M src/hydrogen.h View 2 chunks +10 lines, -10 lines 0 comments Download
M src/hydrogen.cc View 4 chunks +34 lines, -39 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
7 years, 5 months ago (2013-07-19 12:49:36 UTC) #1
Sven Panne
LGTM. Nevertheless, we used to have some naming conventions in hydrogen.{cc,h} regarding Add*/Build*/Handle*Try* methods, but ...
7 years, 5 months ago (2013-07-22 06:57:33 UTC) #2
Benedikt Meurer
7 years, 5 months ago (2013-07-22 07:00:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15789 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698