Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1975893002: Add isolate_android_sdk.py script and android_sdk_hash (Closed)

Created:
4 years, 7 months ago by borenet2
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update SDK to include android_19 and platform-tools #

Patch Set 3 : Use provided SDK #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -1 line) Patch
A + infra/bots/android_sdk.isolate View 1 chunk +1 line, -1 line 0 comments Download
A infra/bots/android_sdk_hash View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A infra/bots/isolate_android_sdk.py View 1 chunk +76 lines, -0 lines 2 comments Download

Messages

Total messages: 15 (6 generated)
borenet
I need to test that this works end-to-end on the bots.
4 years, 7 months ago (2016-05-12 16:32:17 UTC) #3
borenet
This is working in my tests. Ready for review.
4 years, 7 months ago (2016-05-13 14:40:58 UTC) #5
djsollen
is there someone on your team that could review the isolate python code?
4 years, 7 months ago (2016-05-13 14:58:50 UTC) #6
borenet
Ravi is out. Adding Kevin.
4 years, 7 months ago (2016-05-13 15:05:22 UTC) #8
kjlubick
https://codereview.chromium.org/1975893002/diff/40001/infra/bots/isolate_android_sdk.py File infra/bots/isolate_android_sdk.py (right): https://codereview.chromium.org/1975893002/diff/40001/infra/bots/isolate_android_sdk.py#newcode41 infra/bots/isolate_android_sdk.py:41: isolate_cmd = [isolate, 'archive', '--quiet', This command assumes you ...
4 years, 7 months ago (2016-05-13 15:10:21 UTC) #9
borenet
https://codereview.chromium.org/1975893002/diff/40001/infra/bots/isolate_android_sdk.py File infra/bots/isolate_android_sdk.py (right): https://codereview.chromium.org/1975893002/diff/40001/infra/bots/isolate_android_sdk.py#newcode41 infra/bots/isolate_android_sdk.py:41: isolate_cmd = [isolate, 'archive', '--quiet', On 2016/05/13 15:10:21, kjlubick ...
4 years, 7 months ago (2016-05-13 15:15:17 UTC) #10
kjlubick
lgtm
4 years, 7 months ago (2016-05-13 15:16:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975893002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975893002/40001
4 years, 7 months ago (2016-05-13 15:21:52 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 15:41:08 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/4ca5539df5c02fabac9ec1a8d0a0f58a9966347e

Powered by Google App Engine
This is Rietveld 408576698