Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1975873002: Move remaining mus::WindowObserver lifecycle callbacks from PlatformWindowMus to NativeWidgetMus::M… (Closed)

Created:
4 years, 7 months ago by Mark Dittmer
Modified:
4 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina, Fady Samuel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move remaining mus::WindowObserver lifecycle callbacks from PlatformWindowMus to NativeWidgetMus::MusWindowObserver R=sadrul@chromium.org BUG=609555 Committed: https://crrev.com/13982c3193706f64bdbd2bb449f9aa94905a2920 Cr-Commit-Position: refs/heads/master@{#393667}

Patch Set 1 #

Patch Set 2 : rebase from existing branch #

Patch Set 3 : rebase from existing branch #

Patch Set 4 : Remove (mistakenly recursive) Destroy logic from NativeWidgetMus #

Total comments: 1

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -37 lines) Patch
M ui/views/mus/native_widget_mus.cc View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M ui/views/mus/platform_window_mus.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M ui/views/mus/platform_window_mus.cc View 1 3 chunks +0 lines, -30 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Mark Dittmer
4 years, 7 months ago (2016-05-12 16:03:50 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975873002/1
4 years, 7 months ago (2016-05-12 16:03:56 UTC) #3
Mark Dittmer
rebase from existing branch
4 years, 7 months ago (2016-05-12 16:16:46 UTC) #4
Mark Dittmer
rebase from existing branch
4 years, 7 months ago (2016-05-12 16:45:32 UTC) #5
Mark Dittmer
Remove (mistakenly recursive) Destroy logic from NativeWidgetMus
4 years, 7 months ago (2016-05-12 18:30:24 UTC) #6
sadrul
lgtm https://codereview.chromium.org/1975873002/diff/60001/ui/views/mus/native_widget_mus.cc File ui/views/mus/native_widget_mus.cc (right): https://codereview.chromium.org/1975873002/diff/60001/ui/views/mus/native_widget_mus.cc#newcode374 ui/views/mus/native_widget_mus.cc:374: platform_window_delegate()->OnActivationChanged(false); Note that this will probably need to ...
4 years, 7 months ago (2016-05-13 16:46:38 UTC) #7
Mark Dittmer
rebase
4 years, 7 months ago (2016-05-13 21:39:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975873002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975873002/80001
4 years, 7 months ago (2016-05-13 21:40:24 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-13 22:54:12 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 22:55:20 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/13982c3193706f64bdbd2bb449f9aa94905a2920
Cr-Commit-Position: refs/heads/master@{#393667}

Powered by Google App Engine
This is Rietveld 408576698