Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 1975803002: Notification histograms should be thread-safe statics (Closed)

Created:
4 years, 7 months ago by Peter Beverloo
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notification histograms should be thread-safe statics These histograms will be counted on the context thread of the notification, which can differ because notifications are available in both documents and the various kinds of workers. The histograms were re-introduced by the following CL: https://codereview.chromium.org/1904293003/ BUG=592188 Committed: https://crrev.com/2bf6a1f6379b1c1715ea5db0cb65d17e7884563b Cr-Commit-Position: refs/heads/master@{#393252}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
Peter Beverloo
+mvanouwerkerk
4 years, 7 months ago (2016-05-12 13:55:58 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975803002/1
4 years, 7 months ago (2016-05-12 13:56:36 UTC) #5
Michael van Ouwerkerk
Nice, thanks. No idea how that got past the try bots... do we never exercise ...
4 years, 7 months ago (2016-05-12 14:18:57 UTC) #6
Peter Beverloo
On 2016/05/12 14:18:57, Michael van Ouwerkerk wrote: > Nice, thanks. No idea how that got ...
4 years, 7 months ago (2016-05-12 14:29:13 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-12 15:15:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975803002/1
4 years, 7 months ago (2016-05-12 15:20:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 15:23:11 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 15:24:50 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2bf6a1f6379b1c1715ea5db0cb65d17e7884563b
Cr-Commit-Position: refs/heads/master@{#393252}

Powered by Google App Engine
This is Rietveld 408576698