Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 1975763003: Remove Roboto 300 weight from build (Closed)

Created:
4 years, 7 months ago by edwardjung
Modified:
4 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Roboto 300 weight from build Switch the incognito NTP header to 400 as this is the only place using 300 weight. BUG=610517, 609573 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/1ad645ab92ef4d79cca05aeba1a4bfc5aa5a634d Cr-Commit-Position: refs/heads/master@{#393338}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M chrome/browser/resources/ntp4/incognito_and_guest_tab.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/css/roboto.css View 1 chunk +0 lines, -8 lines 0 comments Download
D ui/webui/resources/roboto/roboto-light.woff2 View Binary file 0 comments Download
M ui/webui/resources/webui_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
edwardjung
Dan, please take a look.
4 years, 7 months ago (2016-05-12 14:36:44 UTC) #4
Dan Beam
lgtm
4 years, 7 months ago (2016-05-12 18:21:34 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975763003/1
4 years, 7 months ago (2016-05-12 18:29:17 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-12 19:33:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975763003/1
4 years, 7 months ago (2016-05-12 19:57:21 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 20:00:50 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 20:02:18 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ad645ab92ef4d79cca05aeba1a4bfc5aa5a634d
Cr-Commit-Position: refs/heads/master@{#393338}

Powered by Google App Engine
This is Rietveld 408576698