src/accessors.cc - Issue 1975763002: [runtime] Make sure that LookupIterator::OWN always performs a HIDDEN lookup as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/accessors.cc

Issue 1975763002: [runtime] Make sure that LookupIterator::OWN always performs a HIDDEN lookup as well. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comment Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/accessors.cc

diff --git a/src/accessors.cc b/src/accessors.cc

index 030dc0e58cfaa723a063ecf08f81a3f484c187b2..1b3e7ff99421d43c908bc4500c0e295582bbc00f 100644

--- a/src/accessors.cc

+++ b/src/accessors.cc

@@ -146,6 +146,7 @@ MUST_USE_RESULT MaybeHandle<Object> ReplaceAccessorWithDataProperty(

CHECK(it.HasAccess());

it.Next();

}

+ DCHECK(holder.is_identical_to(it.GetHolder<JSObject>()));

CHECK_EQ(LookupIterator::ACCESSOR, it.state());

it.ReconfigureDataProperty(value, it.property_attributes());

return value;

« no previous file with comments | « no previous file | src/builtins.cc » ('j') | no next file with comments »