Issue 1975753007: ninja/mac: Add horrible workaround for horrible Xcode 7.3 ld bug.

Issue 1975753007: ninja/mac: Add horrible workaround for horrible Xcode 7.3 ld bug. (Closed)

Created:
4 years, 7 months ago by Nico

Modified:
4 years, 7 months ago

Reviewers:
Robert Sesek, Dirk Pranke

CC:
gyp-developer_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/gyp.git@master

Target Ref:
refs/heads/master

Project:
gyp

Visibility:
Public.

More Reviews

Description

ninja/mac: Add horrible workaround for horrible Xcode 7.3 ld bug. BUG=597459 R=rsesek@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/bce1c7793010574d88d7915e2d55395213ac63d1

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	pylib/gyp/xcode_emulation.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Nico

Committed patchset #1 (id:1) manually as bce1c7793010574d88d7915e2d55395213ac63d1 (presubmit successful).

4 years, 7 months ago (2016-05-13 17:43:58 UTC) #5

Nico

4 years, 7 months ago (2016-05-13 20:57:41 UTC) #8

Message was sent while issue was closed.

Excellent question! I'm trying to find that out, but so far I had to fix other
things first (https://codereview.chromium.org/1983443002/, work around
https://bugs.chromium.org/p/chromium/issues/detail?id=611797, and there's some
more stuff left), so I don't know yet. So far, it looks like things Just Work in
gn though.

Looking at ninja -v rlz_unittests, gn seems to not do `-L libboringssl.dylib`
but instead does `./libboringssl.dylib`, so I think it should be fine already.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages