Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1975753006: Pull to refresh: Use new reload type RELOAD_MAIN_RESOURCE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android build fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 75bb31eb4732ef4c141537b0b8d236f3bd05a214..ffab64528c1353f807800f5f2c7965743661c150 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -607,9 +607,39 @@ media::Context3D GetSharedMainThreadContext3D(
}
bool IsReload(FrameMsg_Navigate_Type::Value navigation_type) {
- return navigation_type == FrameMsg_Navigate_Type::RELOAD ||
- navigation_type == FrameMsg_Navigate_Type::RELOAD_BYPASSING_CACHE ||
- navigation_type == FrameMsg_Navigate_Type::RELOAD_ORIGINAL_REQUEST_URL;
+ switch (navigation_type) {
+ case FrameMsg_Navigate_Type::RELOAD:
+ case FrameMsg_Navigate_Type::RELOAD_MAIN_RESOURCE:
+ case FrameMsg_Navigate_Type::RELOAD_BYPASSING_CACHE:
+ case FrameMsg_Navigate_Type::RELOAD_ORIGINAL_REQUEST_URL:
+ return true;
+ case FrameMsg_Navigate_Type::RESTORE:
+ case FrameMsg_Navigate_Type::RESTORE_WITH_POST:
+ case FrameMsg_Navigate_Type::NORMAL:
+ return false;
+ }
+ NOTREACHED();
+ return false;
+}
+
+WebFrameLoadType ReloadFrameLoadTypeFor(
+ FrameMsg_Navigate_Type::Value navigation_type) {
+ switch (navigation_type) {
+ case FrameMsg_Navigate_Type::RELOAD:
+ case FrameMsg_Navigate_Type::RELOAD_ORIGINAL_REQUEST_URL:
+ return WebFrameLoadType::Reload;
+ case FrameMsg_Navigate_Type::RELOAD_MAIN_RESOURCE:
+ return WebFrameLoadType::ReloadMainResource;
+ case FrameMsg_Navigate_Type::RELOAD_BYPASSING_CACHE:
+ return WebFrameLoadType::ReloadBypassingCache;
+ case FrameMsg_Navigate_Type::RESTORE:
+ case FrameMsg_Navigate_Type::RESTORE_WITH_POST:
+ case FrameMsg_Navigate_Type::NORMAL:
+ NOTREACHED();
+ return WebFrameLoadType::Standard;
+ }
+ NOTREACHED();
+ return WebFrameLoadType::Standard;
}
RenderFrameImpl::CreateRenderFrameImplFunction g_create_render_frame_impl =
@@ -5361,10 +5391,7 @@ void RenderFrameImpl::NavigateInternal(
// corresponds to a back/forward navigation event. Update the parameters
// depending on the navigation type.
if (is_reload) {
- bool bypass_cache = (common_params.navigation_type ==
- FrameMsg_Navigate_Type::RELOAD_BYPASSING_CACHE);
- load_type = bypass_cache ? WebFrameLoadType::ReloadBypassingCache
- : WebFrameLoadType::Reload;
+ load_type = ReloadFrameLoadTypeFor(common_params.navigation_type);
if (!browser_side_navigation) {
const GURL override_url =

Powered by Google App Engine
This is Rietveld 408576698