Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1975753006: Pull to refresh: Use new reload type RELOAD_MAIN_RESOURCE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review #14 and #16 Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 79bdb6c8e4208d92625cf513e9fa736178563dc3..793ffdfe7a44f02504b316482ce67786b1823b48 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -606,9 +606,39 @@ media::Context3D GetSharedMainThreadContext3D(
}
bool IsReload(FrameMsg_Navigate_Type::Value navigation_type) {
- return navigation_type == FrameMsg_Navigate_Type::RELOAD ||
- navigation_type == FrameMsg_Navigate_Type::RELOAD_BYPASSING_CACHE ||
- navigation_type == FrameMsg_Navigate_Type::RELOAD_ORIGINAL_REQUEST_URL;
+ switch (navigation_type) {
+ case FrameMsg_Navigate_Type::RELOAD:
+ case FrameMsg_Navigate_Type::RELOAD_MAIN_RESOURCE:
+ case FrameMsg_Navigate_Type::RELOAD_BYPASSING_CACHE:
+ case FrameMsg_Navigate_Type::RELOAD_ORIGINAL_REQUEST_URL:
+ return true;
+ case FrameMsg_Navigate_Type::RESTORE:
+ case FrameMsg_Navigate_Type::RESTORE_WITH_POST:
+ case FrameMsg_Navigate_Type::NORMAL:
+ return false;
+ }
+ NOTREACHED();
+ return false;
+}
+
+WebFrameLoadType ReloadFrameLoadTypeFor(
+ FrameMsg_Navigate_Type::Value navigation_type) {
+ switch (navigation_type) {
+ case FrameMsg_Navigate_Type::RELOAD:
+ case FrameMsg_Navigate_Type::RELOAD_ORIGINAL_REQUEST_URL:
+ return WebFrameLoadType::Reload;
+ case FrameMsg_Navigate_Type::RELOAD_MAIN_RESOURCE:
+ return WebFrameLoadType::ReloadMainResource;
+ case FrameMsg_Navigate_Type::RELOAD_BYPASSING_CACHE:
+ return WebFrameLoadType::ReloadBypassingCache;
+ case FrameMsg_Navigate_Type::RESTORE:
+ case FrameMsg_Navigate_Type::RESTORE_WITH_POST:
+ case FrameMsg_Navigate_Type::NORMAL:
+ NOTREACHED();
+ return WebFrameLoadType::Standard;
+ }
+ NOTREACHED();
+ return WebFrameLoadType::Standard;
}
RenderFrameImpl::CreateRenderFrameImplFunction g_create_render_frame_impl =
@@ -5350,10 +5380,7 @@ void RenderFrameImpl::NavigateInternal(
// corresponds to a back/forward navigation event. Update the parameters
// depending on the navigation type.
if (is_reload) {
- bool bypass_cache = (common_params.navigation_type ==
- FrameMsg_Navigate_Type::RELOAD_BYPASSING_CACHE);
- load_type = bypass_cache ? WebFrameLoadType::ReloadBypassingCache
- : WebFrameLoadType::Reload;
+ load_type = ReloadFrameLoadTypeFor(common_params.navigation_type);
if (!browser_side_navigation) {
const GURL override_url =
« no previous file with comments | « content/public/common/content_features.cc ('k') | third_party/WebKit/Source/core/loader/FrameFetchContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698