use GLB function in strong mode inference

use GLB function in strong mode inference

R=leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/67cb710631eb7255619510c9f065b54b8ddf4b1d

[Jennifer Messerly, 2016-05-13 00:19:56]

jmesserly@google.com changed reviewers:
+ leafp@google.com, paulberry@google.com

[Jennifer Messerly, 2016-05-13 00:24:49]

https://codereview.chromium.org/1975753004/diff/20001/pkg/analyzer/test/src/t...
File pkg/analyzer/test/src/task/strong/inferred_type_test.dart (right):

https://codereview.chromium.org/1975753004/diff/20001/pkg/analyzer/test/src/t...
pkg/analyzer/test/src/task/strong/inferred_type_test.dart:1576: // like not
enough of lambda expressions is implemented.
fyi Paul -- it looks like FunctionElementForLink_Local doesn't implement enough
of FunctionElement for its FunctionType to really to work (specifically
typeParameters are missing, but I also noticed returnType/parameters are missing
-- FunctionTypeImpl can't operate at all without those.)

Looks like the test is exposing something that didn't work already (summarizing
a library which has lambda expressions used in top-level fields). So for now I'm
skipping it. I guess these tests are trying to run in a few different modes now,
I'm mainly concerned about fixing the general inference feature.

[Paul Berry, 2016-05-13 15:31:18]

I'll defer to Leaf for the review, since I'm not terribly familiar with this
corner of type inference yet.

https://codereview.chromium.org/1975753004/diff/20001/pkg/analyzer/test/src/t...
File pkg/analyzer/test/src/task/strong/inferred_type_test.dart (right):

https://codereview.chromium.org/1975753004/diff/20001/pkg/analyzer/test/src/t...
pkg/analyzer/test/src/task/strong/inferred_type_test.dart:1576: // like not
enough of lambda expressions is implemented.
On 2016/05/13 00:24:49, John Messerly wrote:
> fyi Paul -- it looks like FunctionElementForLink_Local doesn't implement
enough
> of FunctionElement for its FunctionType to really to work (specifically
> typeParameters are missing, but I also noticed returnType/parameters are
missing
> -- FunctionTypeImpl can't operate at all without those.)
> 
> Looks like the test is exposing something that didn't work already
(summarizing
> a library which has lambda expressions used in top-level fields). So for now
I'm
> skipping it. I guess these tests are trying to run in a few different modes
now,
> I'm mainly concerned about fixing the general inference feature.
> 

Thanks for the heads up.  Our usual way of disabling tests that don't work with
summaries is to add an override with a "@failingTest" annotation in
AstInferredTypeTest (pkg/analyzer/test/src/summary/resynthesize_ast_test.dart). 
That has the advantage that it causes the test runner to check that the test
fails, so that once we've implemented enough functionality for the test to start
passing, we'll be alerted.

But in any case I'll follow up once this CL lands and make sure the appropriate
functionality gets implemented.

[Jennifer Messerly, 2016-05-13 16:55:23]

https://codereview.chromium.org/1975753004/diff/20001/pkg/analyzer/test/src/t...
File pkg/analyzer/test/src/task/strong/inferred_type_test.dart (right):

https://codereview.chromium.org/1975753004/diff/20001/pkg/analyzer/test/src/t...
pkg/analyzer/test/src/task/strong/inferred_type_test.dart:1576: // like not
enough of lambda expressions is implemented.
On 2016/05/13 15:31:18, Paul Berry wrote:
> On 2016/05/13 00:24:49, John Messerly wrote:
> > fyi Paul -- it looks like FunctionElementForLink_Local doesn't implement
> enough
> > of FunctionElement for its FunctionType to really to work (specifically
> > typeParameters are missing, but I also noticed returnType/parameters are
> missing
> > -- FunctionTypeImpl can't operate at all without those.)
> > 
> > Looks like the test is exposing something that didn't work already
> (summarizing
> > a library which has lambda expressions used in top-level fields). So for now
> I'm
> > skipping it. I guess these tests are trying to run in a few different modes
> now,
> > I'm mainly concerned about fixing the general inference feature.
> > 
> 
> Thanks for the heads up.  Our usual way of disabling tests that don't work
with
> summaries is to add an override with a "@failingTest" annotation in
> AstInferredTypeTest
(pkg/analyzer/test/src/summary/resynthesize_ast_test.dart). 
> That has the advantage that it causes the test runner to check that the test
> fails, so that once we've implemented enough functionality for the test to
start
> passing, we'll be alerted.
> 
> But in any case I'll follow up once this CL lands and make sure the
appropriate
> functionality gets implemented.

Ah, thank you, I was wondering how that worked. Done!

[Jennifer Messerly, 2016-05-13 17:28:52]

@Leaf -- I also added some comments to make it a little more clear what is going
on in that function

[Leaf, 2016-05-14 01:46:16]

lgtm

[Jennifer Messerly, 2016-05-17 18:04:43]

Description was changed from

==========
use GLB function in strong mode inference
==========

to

==========
use GLB function in strong mode inference

R=leafp@google.com

Committed:
https://github.com/dart-lang/sdk/commit/67cb710631eb7255619510c9f065b54b8ddf4b1d
==========

[Jennifer Messerly, 2016-05-17 18:04:45]

Committed patchset #4 (id:60001) manually as
67cb710631eb7255619510c9f065b54b8ddf4b1d (presubmit successful).