Stores per-iteration bench values in BenchDataPoint.

Stores per-iteration bench values in BenchDataPoint.

BUG=skia:2225
NOTRY=true

Committed: http://code.google.com/p/skia/source/detail?r=13767

[benchen, 2014-03-12 15:23:28]

This will be used later in calculating bench expectation ranges.

[borenet, 2014-03-12 15:54:32]

LGTM with request for documentation tweak.  This is a little confusing, but I'm
not sure what can be done about it.

https://codereview.chromium.org/197573002/diff/20001/bench/bench_util.py
File bench/bench_util.py (right):

https://codereview.chromium.org/197573002/diff/20001/bench/bench_util.py#newc...
bench/bench_util.py:42: (str, str, str, float, {str:str}, str, [floats],
[floats])"""
I'd really prefer to have these parameters documented per-argument with some
explanation.

[benchen, 2014-03-12 16:22:51]

Thanks, PTAL.

https://codereview.chromium.org/197573002/diff/20001/bench/bench_util.py
File bench/bench_util.py (right):

https://codereview.chromium.org/197573002/diff/20001/bench/bench_util.py#newc...
bench/bench_util.py:42: (str, str, str, float, {str:str}, str, [floats],
[floats])"""
On 2014/03/12 15:54:32, borenet wrote:
> I'd really prefer to have these parameters documented per-argument with some
> explanation.

They are member variables. I added explanations in __init__. Sorry for the
historical confusion.

[benchen, 2014-03-12 16:23:19]

The CQ bit was checked by bensong@google.com

[commit-bot: I haz the power, 2014-03-12 16:23:23]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bensong@google.com/197573002/40001

[commit-bot: I haz the power, 2014-03-12 16:23:36]

Change committed as 13767

[borenet, 2014-03-12 17:13:06]

https://codereview.chromium.org/197573002/diff/20001/bench/bench_util.py
File bench/bench_util.py (right):

https://codereview.chromium.org/197573002/diff/20001/bench/bench_util.py#newc...
bench/bench_util.py:42: (str, str, str, float, {str:str}, str, [floats],
[floats])"""
On 2014/03/12 16:22:51, benchen wrote:
> On 2014/03/12 15:54:32, borenet wrote:
> > I'd really prefer to have these parameters documented per-argument with some
> > explanation.
> 
> They are member variables. I added explanations in __init__. Sorry for the
> historical confusion.

Thanks.  This is okay, but I'd still prefer the documentation to be in the
docstring for __init__, like this:

def __init__(....):
  """Instantiate a BenchDataPoint.

  Args:
    bench: string; name of the benchmark to measure
    .... etc ....
  """