DevTools: fix janky transition in sensors panel

DevTools: fix janky transition in sensors panel

BUG=609718
Committed: https://crrev.com/491764de4a847d265bb538b661e0f0eb078c7d3d
Cr-Commit-Position: refs/heads/master@{#394572}

[luoe, 2016-05-12 21:30:54]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[luoe, 2016-05-12 21:30:54]

This CL updates our CSS 3D transforms from "matrix3d" to use "rotate3d()".  By
avoiding directly setting transform matrices, we avoid the janky animation
behavior.

[luoe, 2016-05-12 21:32:09]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 21:32:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1975723003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1975723003/1

[commit-bot: I haz the power, 2016-05-12 22:23:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 22:23:19]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[luoe, 2016-05-13 02:26:59]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-13 02:27:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1975723003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1975723003/20001

[commit-bot: I haz the power, 2016-05-13 03:30:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 03:30:52]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-05-16 21:51:08]

lgtm

https://codereview.chromium.org/1975723003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/common/Geometry.js (right):

https://codereview.chromium.org/1975723003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/common/Geometry.js:293:
WebInspector.Geometry.degToRad = function(deg)
.toRadians = 

We avoid abbreviations as much as possible

https://codereview.chromium.org/1975723003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js
(right):

https://codereview.chromium.org/1975723003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js:265: var
noAnimation = modificationSource ===
WebInspector.SensorsView.DeviceOrientationModificationSource.UserDrag;
var animate = ...

https://codereview.chromium.org/1975723003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js:315: *
@param {boolean=} noAnimation
let's pass a non-optional "animate" parameter here

https://codereview.chromium.org/1975723003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js:376:
this._originalBoxMatrix = this._boxMatrix.scale(1);
what is this for?

[luoe, 2016-05-16 22:15:57]

https://codereview.chromium.org/1975723003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/common/Geometry.js (right):

https://codereview.chromium.org/1975723003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/common/Geometry.js:293:
WebInspector.Geometry.degToRad = function(deg)
On 2016/05/16 21:51:08, lushnikov wrote:
> .toRadians = 
> 
> We avoid abbreviations as much as possible 

Sounds good.  I was trying to match the style of
"WebInspector.Geometry.radToDeg" which I found below.  I can change those
instances to radiansToDegrees as well.

https://codereview.chromium.org/1975723003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js
(right):

https://codereview.chromium.org/1975723003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js:265: var
noAnimation = modificationSource ===
WebInspector.SensorsView.DeviceOrientationModificationSource.UserDrag;
On 2016/05/16 21:51:08, lushnikov wrote:
> var animate = ...

Done.

https://codereview.chromium.org/1975723003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js:315: *
@param {boolean=} noAnimation
On 2016/05/16 21:51:08, lushnikov wrote:
> let's pass a non-optional "animate" parameter here

Done.

https://codereview.chromium.org/1975723003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js:376:
this._originalBoxMatrix = this._boxMatrix.scale(1);
On 2016/05/16 21:51:08, lushnikov wrote:
> what is this for?

Ah, no need for this anymore!  I was originally using it as a .clone(), but this
is the only place where originalBoxMatrix is set, so it's not necessary to
clone.

[luoe, 2016-05-16 22:17:39]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-16 22:18:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1975723003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1975723003/40001

[commit-bot: I haz the power, 2016-05-16 23:59:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-16 23:59:17]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[luoe, 2016-05-18 00:54:29]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-18 00:55:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1975723003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1975723003/60001

[commit-bot: I haz the power, 2016-05-18 04:55:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 04:55:55]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[luoe, 2016-05-18 20:42:57]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-18 20:43:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1975723003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1975723003/60001

[commit-bot: I haz the power, 2016-05-18 22:12:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 22:12:30]

Dry run: This issue passed the CQ dry run.

[luoe, 2016-05-18 22:14:24]

The CQ bit was checked by luoe@chromium.org

[luoe, 2016-05-18 22:14:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/1975723003/#ps60001
(title: "updated test and rebase")

[commit-bot: I haz the power, 2016-05-18 22:14:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1975723003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1975723003/60001

[commit-bot: I haz the power, 2016-05-18 22:20:04]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-18 22:21:24]

Description was changed from

==========
DevTools: fix janky transition in sensors panel

BUG=609718
==========

to

==========
DevTools: fix janky transition in sensors panel

BUG=609718

Committed: https://crrev.com/491764de4a847d265bb538b661e0f0eb078c7d3d
Cr-Commit-Position: refs/heads/master@{#394572}
==========

[commit-bot: I haz the power, 2016-05-18 22:21:26]

Patchset 4 (id:??) landed as
https://crrev.com/491764de4a847d265bb538b661e0f0eb078c7d3d
Cr-Commit-Position: refs/heads/master@{#394572}