Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1975713003: Only call OS::GetCurrentThreadCPUMicros when a TimelineDurationScope is enabled (Closed)

Created:
4 years, 7 months ago by Cutch
Modified:
4 years, 7 months ago
Reviewers:
rmacnak, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Only call OS::GetCurrentThreadCPUMicros when a TimelineDurationScope is enabled OS::GetCurrentThreadCPUMicros is expensive on Mac. Fixes #26423 R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/6b270752f65964666340112283302fce518a2a1c

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/timeline.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Cutch
4 years, 7 months ago (2016-05-12 18:43:28 UTC) #3
Ivan Posva
LGTM -ip https://codereview.chromium.org/1975713003/diff/1/runtime/vm/timeline.cc File runtime/vm/timeline.cc (right): https://codereview.chromium.org/1975713003/diff/1/runtime/vm/timeline.cc#newcode901 runtime/vm/timeline.cc:901: if (!FLAG_support_timeline) { if (!FLAG_support_timeline || !enabled()) ...
4 years, 7 months ago (2016-05-12 18:47:47 UTC) #6
Cutch
https://codereview.chromium.org/1975713003/diff/1/runtime/vm/timeline.cc File runtime/vm/timeline.cc (right): https://codereview.chromium.org/1975713003/diff/1/runtime/vm/timeline.cc#newcode901 runtime/vm/timeline.cc:901: if (!FLAG_support_timeline) { On 2016/05/12 18:47:46, Ivan Posva wrote: ...
4 years, 7 months ago (2016-05-12 20:06:22 UTC) #7
Cutch
4 years, 7 months ago (2016-05-12 20:06:31 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
6b270752f65964666340112283302fce518a2a1c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698