Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: snapshot_toolchain.gni

Issue 1975713002: Revert of Change v8_snapshot_toolchain to be a GN build arg. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 the V8 project authors. All rights reserved. 1 # Copyright 2015 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
11 # with the distribution. 11 # with the distribution.
12 # * Neither the name of Google Inc. nor the names of its 12 # * Neither the name of Google Inc. nor the names of its
13 # contributors may be used to endorse or promote products derived 13 # contributors may be used to endorse or promote products derived
14 # from this software without specific prior written permission. 14 # from this software without specific prior written permission.
15 # 15 #
16 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 # "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 # "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 # LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 # LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 # A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 # A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 # OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 # OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 declare_args() { 28 # The snapshot needs to be compiled for the host, but compiled with
29 # The snapshot needs to be compiled for the host, but compiled with 29 # a toolchain that matches the bit-width of the target.
30 # a toolchain that matches the bit-width of the target.
31 v8_snapshot_toolchain = ""
32 }
33 30
34 # TODO(GYP): For now we only support 32-bit little-endian target builds from an 31 # TODO(GYP): For now we only support 32-bit little-endian target builds from an
35 # x64 Linux host. Eventually we need to support all of the host/target 32 # x64 Linux host. Eventually we need to support all of the host/target
36 # configurations v8 runs on. 33 # configurations v8 runs on.
37 if (v8_snapshot_toolchain == "") { 34 if (host_cpu == "x64" && host_os == "linux") {
38 if (host_cpu == "x64" && host_os == "linux") { 35 if (target_cpu == "arm" || target_cpu == "mipsel" || target_cpu == "x86") {
39 if (target_cpu == "arm" || target_cpu == "mipsel" || target_cpu == "x86") { 36 snapshot_toolchain = "//build/toolchain/linux:clang_x86"
40 if (target_os == "android" || is_clang) { 37 } else if (target_cpu == "x64" || target_cpu == "arm64" || target_cpu == "mips 64el") {
41 v8_snapshot_toolchain = "//build/toolchain/linux:clang_x86" 38 snapshot_toolchain = "//build/toolchain/linux:clang_x64"
42 } else {
43 v8_snapshot_toolchain = "//build/toolchain/linux:x86"
44 }
45
46 } else if (target_cpu == "x64" || target_cpu == "arm64" ||
47 target_cpu == "mips64el") {
48 if (target_os == "android" || is_clang) {
49 v8_snapshot_toolchain = "//build/toolchain/linux:clang_x64"
50 } else {
51 v8_snapshot_toolchain = "//build/toolchain/linux:x64"
52 }
53 } else {
54 assert(false, "Need environment for this arch: $target_cpu")
55 }
56 } else { 39 } else {
57 v8_snapshot_toolchain = default_toolchain 40 assert(false, "Need environment for this arch: $target_cpu")
58 } 41 }
42 } else {
43 snapshot_toolchain = default_toolchain
59 } 44 }
60 45
61 # TODO(GYP): snapshot_toolchain is provided for backwards compatibility 46
62 # and should be removed once all callers are updated to refer to
63 # v8_snapshot_toolchain directly.
64 snapshot_toolchain = v8_snapshot_toolchain
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698