content/renderer/webcrypto_impl_openssl.cc - Issue 19757011: WebCrypto: Implement digest() using NSS

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/renderer/webcrypto_impl_openssl.cc

Issue 19757011: WebCrypto: Implement digest() using NSS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix leak of hash context. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/renderer/webcrypto_impl_nss.cc ('K') | « content/renderer/webcrypto_impl_nss.cc ('k') | content/renderer/webcrypto_impl_unittest.cc » ('j') | content/renderer/webcrypto_impl_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "content/renderer/webcrypto_impl.h"

	6

	7 namespace content {

	8

	9 void WebCryptoImpl::digest(

	10 const WebKit::WebCryptoAlgorithm& algorithm,

	11 const unsigned char* data,

	12 size_t data_size,

	13 WebKit::WebCryptoResult result) {

	14 // TODO(bryaneyler): Placeholder for OpenSSL implementation. Issue 267888.

	15 (void)algorithm;
	eroman 2013/08/22 23:15:12 What is the purpose of these (void)? If you are g What is the purpose of these (void)? If you are getting an unreferenced variable warning from the compiler, I would just delete the names from the argument list above. Bryan Eyler 2013/08/23 01:22:11 This was more just preemptive to avoid a compiler Show quoted text On 2013/08/22 23:15:12, eroman wrote: > What is the purpose of these (void)? > > If you are getting an unreferenced variable warning from the compiler, I would > just delete the names from the argument list above. This was more just preemptive to avoid a compiler warning. Removed and will see if Try returns any errors. jamesr 2013/08/23 01:27:40 I don't think we generate such warnings. Just remo Show quoted text On 2013/08/22 23:15:12, eroman wrote: > What is the purpose of these (void)? > > If you are getting an unreferenced variable warning from the compiler, I would > just delete the names from the argument list above. I don't think we generate such warnings. Just remove these.
	16 (void)data;

	17 (void)data_size;

	18 result.completeWithError();

	19 }

	20

	21 } // namespace content

OLD	NEW