WebCrypto: Implement digest() using NSS

content/renderer/webcrypto_impl_nss.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/renderer/webcrypto_impl.h"
+
+#include <sechash.h>
+
+#include "base/logging.h"
+#include "crypto/nss_util.h"
+#include "third_party/WebKit/public/platform/WebArrayBuffer.h"
+#include "third_party/WebKit/public/platform/WebCryptoAlgorithm.h"
+
+namespace content {
+
+void WebCryptoImpl::digest(
+    const WebKit::WebCryptoAlgorithm& algorithm,
+    const unsigned char* data,
+    size_t data_size,
+    WebKit::WebCryptoResult result) {
+  HASH_HashType hash_type = HASH_AlgNULL;
+
+  switch (algorithm.id()) {
+    case WebKit::WebCryptoAlgorithmIdSha1:
+      hash_type = HASH_AlgSHA1;
+      break;
+    case WebKit::WebCryptoAlgorithmIdSha224:
+      hash_type = HASH_AlgSHA224;
+      break;
+    case WebKit::WebCryptoAlgorithmIdSha256:
+      hash_type = HASH_AlgSHA256;
+      break;
+    case WebKit::WebCryptoAlgorithmIdSha384:
+      hash_type = HASH_AlgSHA384;
+      break;
+    case WebKit::WebCryptoAlgorithmIdSha512:
+      hash_type = HASH_AlgSHA512;
+      break;
+    default:
+      // Not a digest algorithm.
+      result.completeWithError();
+      return;
+  }
+
+  crypto::EnsureNSSInit();
+
+  HASHContext* context = HASH_Create(hash_type);
+  if (!context) {
+    result.completeWithError();
+    return;
+  }
+
+  HASH_Begin(context);
+
+  HASH_Update(context, data, data_size);
+
+  size_t hash_result_length = HASH_ResultLenContext(context);
+  DCHECK(hash_result_length <= HASH_LENGTH_MAX);
+
+  WebKit::WebArrayBuffer buffer(
+      WebKit::WebArrayBuffer::create(hash_result_length, 1));
+
+  unsigned char* digest = reinterpret_cast<unsigned char*>(buffer.data());
+
+  uint32 result_length = 0;
+  HASH_End(context, digest, &result_length, hash_result_length);
+  if (result_length != hash_result_length) {
+    result.completeWithError();
+    return;
+  }
+

[eroman, 2013/08/22 22:59:01]

I believe the HASHContext* is getting leaked (not calling HASH_Destroy).

There are two paths where control returns without freeing it. Either add a
scoped deleter, or update those two locations.

[Bryan Eyler, 2013/08/22 23:07:06]

Done.

+  result.completeWithBuffer(buffer);
+}
+
+}  // namespace content