LogDog: Implement prefix registration in Butler.

LogDog: Implement prefix registration in Butler.

Implement the prefix registration protocol in Butler. The Butler will now
connect to the "RegisterPrefix" endpoint on creation to register its
prefix and obtain its stream creation secret for that prefix.

This causes output creation to happen immediately before process spawning. Secret is
now an optional parameter and supplied by the Coordinator.

Do some Butler code cleanup and reorganization now that its final form
is taking shape.

BUG=

Committed: https://github.com/luci/luci-go/commit/64d2557248bd6211b50d7f636cc87388227b47c4

[dnj (Google), 2016-05-12 02:43:27]

dnj@google.com changed reviewers:
+ dnj@google.com, iannucci@chromium.org, nodir@chromium.org

[dnj (Google), 2016-05-12 02:43:27]

PTAL. See chain of CLs for context. After this, Butler will be able to fully
register and own a stream prefix!

[dnj, 2016-05-17 20:43:04]

Description was changed from

==========
LogDog: Implement prefix registration in Butler.

Implement the prefix registration protocol in Butler. Move output
creation to immediately before process spawning. Secret is now an
optional parameter and supplied by the Coordinator.

Do some Butler code cleanup and reorganization now that its final form
is taking shape.

BUG=
==========

to

==========
LogDog: Implement prefix registration in Butler.

Implement the prefix registration protocol in Butler. The Butler will now
connect to the "RegisterPrefix" endpoint on creation to register its
prefix and obtain its stream creation secret for that prefix.

This moves output creation to immediately before process spawning. Secret is
now an optional parameter and supplied by the Coordinator.

Do some Butler code cleanup and reorganization now that its final form
is taking shape.

BUG=
==========

[nodir, 2016-05-19 01:38:12]

"This moves output creation to immediately"
"be" missing?

[nodir, 2016-05-19 02:04:44]

https://codereview.chromium.org/1975683002/diff/20001/client/cmd/logdog_butle...
File client/cmd/logdog_butler/output_logdog.go (right):

https://codereview.chromium.org/1975683002/diff/20001/client/cmd/logdog_butle...
client/cmd/logdog_butler/output_logdog.go:187: err := retry.Retry(ctx,
retry.TransientOnly(retry.Default), func() (err error) {
I am not sure rc.inner.RegisterPrefix ever returns an error which is
errors.IsTransient

https://codereview.chromium.org/1975683002/diff/20001/client/cmd/logdog_butle...
client/cmd/logdog_butler/output_logdog.go:188: resp, err =
rc.inner.RegisterPrefix(ctx, req)
it already does retries

[dnj (Google), 2016-05-19 02:08:30]

Description was changed from

==========
LogDog: Implement prefix registration in Butler.

Implement the prefix registration protocol in Butler. The Butler will now
connect to the "RegisterPrefix" endpoint on creation to register its
prefix and obtain its stream creation secret for that prefix.

This moves output creation to immediately before process spawning. Secret is
now an optional parameter and supplied by the Coordinator.

Do some Butler code cleanup and reorganization now that its final form
is taking shape.

BUG=
==========

to

==========
LogDog: Implement prefix registration in Butler.

Implement the prefix registration protocol in Butler. The Butler will now
connect to the "RegisterPrefix" endpoint on creation to register its
prefix and obtain its stream creation secret for that prefix.

This causes output creation to happen immediately before process spawning.
Secret is
now an optional parameter and supplied by the Coordinator.

Do some Butler code cleanup and reorganization now that its final form
is taking shape.

BUG=
==========

[dnj (Google), 2016-05-19 02:09:36]

https://codereview.chromium.org/1975683002/diff/20001/client/cmd/logdog_butle...
File client/cmd/logdog_butler/output_logdog.go (right):

https://codereview.chromium.org/1975683002/diff/20001/client/cmd/logdog_butle...
client/cmd/logdog_butler/output_logdog.go:187: err := retry.Retry(ctx,
retry.TransientOnly(retry.Default), func() (err error) {
On 2016/05/19 02:04:44, nodir wrote:
> I am not sure rc.inner.RegisterPrefix ever returns an error which is
> errors.IsTransient

Okay, I'll remove this entire retry block.

https://codereview.chromium.org/1975683002/diff/20001/client/cmd/logdog_butle...
client/cmd/logdog_butler/output_logdog.go:188: resp, err =
rc.inner.RegisterPrefix(ctx, req)
On 2016/05/19 02:04:44, nodir wrote:
> it already does retries

Good point. I'll remove this. But weren't we planning on potentially disabling
this behavior b/c gRPC doesn't?

[nodir, 2016-05-19 16:46:40]

lgtm

https://codereview.chromium.org/1975683002/diff/20001/client/cmd/logdog_butle...
File client/cmd/logdog_butler/output_logdog.go (right):

https://codereview.chromium.org/1975683002/diff/20001/client/cmd/logdog_butle...
client/cmd/logdog_butler/output_logdog.go:188: resp, err =
rc.inner.RegisterPrefix(ctx, req)
On 2016/05/19 02:09:35, dnj (Google) wrote:
> On 2016/05/19 02:04:44, nodir wrote:
> > it already does retries
> 
> Good point. I'll remove this. But weren't we planning on potentially disabling
> this behavior b/c gRPC doesn't?

yeah, we were planning to make a "luci" client and update all callsite once and
for all, but nobody got time for that

[dnj (Google), 2016-05-27 16:53:40]

The CQ bit was checked by dnj@google.com

[dnj (Google), 2016-05-27 16:53:40]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/1975683002/#ps100001
(title: "Rebarse")

[commit-bot: I haz the power, 2016-05-27 16:53:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1975683002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1975683002/100001

[commit-bot: I haz the power, 2016-05-27 16:58:23]

Description was changed from

==========
LogDog: Implement prefix registration in Butler.

Implement the prefix registration protocol in Butler. The Butler will now
connect to the "RegisterPrefix" endpoint on creation to register its
prefix and obtain its stream creation secret for that prefix.

This causes output creation to happen immediately before process spawning.
Secret is
now an optional parameter and supplied by the Coordinator.

Do some Butler code cleanup and reorganization now that its final form
is taking shape.

BUG=
==========

to

==========
LogDog: Implement prefix registration in Butler.

Implement the prefix registration protocol in Butler. The Butler will now
connect to the "RegisterPrefix" endpoint on creation to register its
prefix and obtain its stream creation secret for that prefix.

This causes output creation to happen immediately before process spawning.
Secret is
now an optional parameter and supplied by the Coordinator.

Do some Butler code cleanup and reorganization now that its final form
is taking shape.

BUG=

Committed:
https://github.com/luci/luci-go/commit/64d2557248bd6211b50d7f636cc87388227b47c4
==========

[commit-bot: I haz the power, 2016-05-27 16:58:25]

Committed patchset #6 (id:100001) as
https://github.com/luci/luci-go/commit/64d2557248bd6211b50d7f636cc87388227b47c4