add 'langauge settings' link to the translate bubble advanced view

chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/translate/translate_bubble_controller.h"
 
 #include <utility>
 
 #include "base/mac/foundation_util.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/macros.h"
 #include "base/strings/sys_string_conversions.h"
+#include "chrome/browser/ui/chrome_pages.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 #import "chrome/browser/ui/cocoa/bubble_combobox.h"
 #import "chrome/browser/ui/cocoa/info_bubble_view.h"
 #import "chrome/browser/ui/cocoa/info_bubble_window.h"
 #import "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
 #include "chrome/browser/ui/translate/language_combobox_model.h"
 #include "chrome/browser/ui/translate/translate_bubble_model_impl.h"
+#include "chrome/common/url_constants.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/translate/core/browser/translate_ui_delegate.h"
 #include "content/public/browser/browser_context.h"
+#include "content/public/common/referrer.h"
 #include "grit/components_strings.h"
 #include "ui/base/cocoa/cocoa_base_utils.h"
 #import "ui/base/cocoa/controls/hyperlink_button_cell.h"
 #import "ui/base/cocoa/window_size_constants.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/models/combobox_model.h"
 
 // TODO(hajimehoshi): This class is almost same as that of views. Refactor them.
 class TranslateDenialComboboxModel : public ui::ComboboxModel {
  public:
@@ skipping 60 matching lines @@
 - (NSButton*)addCheckbox:(NSString*)title
                   toView:(NSView*)view;
 - (NSPopUpButton*)addPopUpButton:(ui::ComboboxModel*)model
                           action:(SEL)action
                           toView:(NSView*)view;
 - (void)handleNopeButtonPressed;
 - (void)handleDoneButtonPressed;
 - (void)handleCancelButtonPressed;
 - (void)handleShowOriginalButtonPressed;
 - (void)handleAdvancedLinkButtonPressed;
+- (void)handleLanguageSettingsLinkButtonPressed;
 - (void)handleDenialPopUpButtonNopeSelected;
 - (void)handleDenialPopUpButtonNeverTranslateLanguageSelected;
 - (void)handleDenialPopUpButtonNeverTranslateSiteSelected;
 - (void)handleSourceLanguagePopUpButtonSelectedItemChanged:(id)sender;
 - (void)handleTargetLanguagePopUpButtonSelectedItemChanged:(id)sender;
 
 @end
 
 @implementation TranslateBubbleController
 
@@ skipping 316 matching lines @@
   // Buttons
   advancedDoneButton_ =
       [self addButton:l10n_util::GetNSStringWithFixup(IDS_DONE)
                action:@selector(handleDoneButtonPressed)
                toView:view];
   advancedCancelButton_ =
       [self addButton:l10n_util::GetNSStringWithFixup(IDS_CANCEL)
                action:@selector(handleCancelButtonPressed)
                toView:view];
 
+  NSString* message = l10n_util::GetNSStringWithFixup(
+      IDS_TRANSLATE_BUBBLE_LANGUAGE_SETTINGS);
+  advancedLanguageSettingsLinkButton_ =
+      [self addLinkButtonWithText:message

[groby-ooo-7-16, 2016/05/12 01:23:40]

I think advancedLanguageSettingsLinkButton_ can be a local variable - you don't
use it anywhere else.

[ftang, 2016/05/12 04:45:21]

Done.

+                           action:@selector(handleLanguageSettingsLinkButtonPressed)
+                           toView:view];
+
   // Layout
   CGFloat textLabelWidth = NSWidth([sourceLanguageLabel frame]);
   if (textLabelWidth < NSWidth([targetLanguageLabel frame]))
     textLabelWidth = NSWidth([targetLanguageLabel frame]);
 
   CGFloat yPos = 0;
 
   [advancedDoneButton_ setFrameOrigin:NSMakePoint(0, yPos)];
   [advancedCancelButton_ setFrameOrigin:NSMakePoint(0, yPos)];
 
-  yPos += NSHeight([advancedDoneButton_ frame]) +
+  [advancedLanguageSettingsLinkButton_ setFrameOrigin:NSMakePoint(0, yPos)];
+
+  // The height of the buttons and link are different. Place the
+  // origin of the link up.

[groby-ooo-7-16, 2016/05/12 01:23:40]

Up relative to what? Do you mean center it w/ the done button, or do I misread
the code?

[ftang, 2016/05/12 04:45:21]

Done.

+  yPos = (NSHeight([advancedDoneButton_ frame]) -
+         NSHeight([advancedLanguageSettingsLinkButton_ frame])) / 2;
+
+  [advancedLanguageSettingsLinkButton_ setFrameOrigin:NSMakePoint(0, yPos)];
+
+  yPos = NSHeight([advancedDoneButton_ frame]) +
       kUnrelatedControlVerticalSpacing;
 
   if (alwaysTranslateCheckbox_) {
     [alwaysTranslateCheckbox_ setFrameOrigin:NSMakePoint(textLabelWidth, yPos)];
 
     yPos += NSHeight([alwaysTranslateCheckbox_ frame]) +
         kRelatedControlVerticalSpacing;
   }
 
   CGFloat diffY = [[sourcePopUpButton cell]
@@ skipping 163 matching lines @@
 
 - (void)handleShowOriginalButtonPressed {
   model_->RevertTranslation();
   [self close];
 }
 
 - (void)handleAdvancedLinkButtonPressed {
   [self switchView:TranslateBubbleModel::VIEW_STATE_ADVANCED];
 }
 
+- (void)handleLanguageSettingsLinkButtonPressed {
+  GURL url = chrome::GetSettingsUrl(chrome::kLanguageOptionsSubPage);

[groby-ooo-7-16, 2016/05/12 01:23:39]

It would be nice if this could be a shared function on the model :) (I know, I
repeat myself)

[ftang, 2016/05/12 04:45:21]

are you talking about TranslateBubbleModel ?

[ftang, 2016/05/12 06:16:02]

I try to move it to TranslateBubbleModel or TranslateUIDelegate  but either will
cause linking/dependcy issues. I have to rollback to put into .mm file and
view.cc file.

+  webContents_->OpenURL(
+      content::OpenURLParams(url, content::Referrer(), NEW_FOREGROUND_TAB,
+                             ui::PAGE_TRANSITION_LINK, false));
+  [self close];
+}
+
 - (void)handleDenialPopUpButtonNopeSelected {
   model_->DeclineTranslation();
   [self close];
 }
 
 - (void)handleDenialPopUpButtonNeverTranslateLanguageSelected {
   model_->DeclineTranslation();
   model_->SetNeverTranslateLanguage(true);
   [self close];
 }
@@ skipping 10 matching lines @@
   [self updateAdvancedView];
 }
 
 - (void)handleTargetLanguagePopUpButtonSelectedItemChanged:(id)sender {
   NSPopUpButton* button = base::mac::ObjCCastStrict<NSPopUpButton>(sender);
   model_->UpdateTargetLanguageIndex([button indexOfSelectedItem]);
   [self updateAdvancedView];
 }
 
 @end