Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Issue 1975643002: Update export_tarball.py (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update export_tarball.py - Exclude .git directories only. Stop mentioning SVN. - Exclude the out directory. - Remove obsolete non-essential directories from the list. - Move some non-essential directories to the test data list. - Add a list of essential files to override the non-essential dir list. BUG=611199

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -33 lines) Patch
M tools/export_tarball/export_tarball.py View 6 chunks +27 lines, -33 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Lei Zhang
4 years, 7 months ago (2016-05-12 16:59:16 UTC) #3
Paweł Hajdan Jr.
The changes look good. However, the real copy that is used is https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/recipe_modules/chromium/resources/export_tarball.py&q=export_tarball.py&sq=package:chromium&type=cs&l=14 I suggest ...
4 years, 7 months ago (2016-05-13 10:40:12 UTC) #4
Lei Zhang
On 2016/05/13 10:40:12, Paweł Hajdan Jr. wrote: > The changes look good. > > However, ...
4 years, 7 months ago (2016-05-13 17:50:16 UTC) #5
Lei Zhang
On 2016/05/13 17:50:16, Lei Zhang wrote: > Huh. Why does it even exist in the ...
4 years, 7 months ago (2016-05-13 20:20:28 UTC) #6
Lei Zhang
On 2016/05/13 10:40:12, Paweł Hajdan Jr. wrote: > However, the real copy that is used ...
4 years, 7 months ago (2016-05-13 20:33:54 UTC) #7
Paweł Hajdan Jr.
On 2016/05/13 at 20:20:28, thestig wrote: > On 2016/05/13 17:50:16, Lei Zhang wrote: > > ...
4 years, 7 months ago (2016-05-16 09:57:42 UTC) #8
Lei Zhang
4 years, 7 months ago (2016-05-16 18:39:41 UTC) #9
On 2016/05/16 09:57:42, Paweł Hajdan Jr. wrote:
> On 2016/05/13 at 20:20:28, thestig wrote:
> > On 2016/05/13 17:50:16, Lei Zhang wrote:
> > > Huh. Why does it even exist in the first place?
> > 
> > And what about export_v8_tarball.py? I don't see it in
build/scripts/slave/...
> Is it not in use anymore?
> 
> Yeah, it's unused.

Deletion CL: https://codereview.chromium.org/1983943002

Powered by Google App Engine
This is Rietveld 408576698