Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1626)

Unified Diff: cc/trees/property_tree.cc

Issue 1975623002: cc : Add LayerToPropertyTreeIndices map to PropertyTrees (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/property_tree.h ('k') | cc/trees/property_tree_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/property_tree.cc
diff --git a/cc/trees/property_tree.cc b/cc/trees/property_tree.cc
index 6af13f64723a9c70d387da42f7e359a680df3faf..74cad2ab2d8c1ad687b76280a571bf8051a6c55e 100644
--- a/cc/trees/property_tree.cc
+++ b/cc/trees/property_tree.cc
@@ -117,7 +117,9 @@ void PropertyTree<T>::ToProtobuf(proto::PropertyTree* proto) const {
}
template <typename T>
-void PropertyTree<T>::FromProtobuf(const proto::PropertyTree& proto) {
+void PropertyTree<T>::FromProtobuf(
+ const proto::PropertyTree& proto,
+ std::unordered_map<int, int>* node_id_to_index_map) {
// Verify that the property tree is empty.
DCHECK_EQ(static_cast<int>(nodes_.size()), 1);
DCHECK_EQ(back()->id, 0);
@@ -127,9 +129,11 @@ void PropertyTree<T>::FromProtobuf(const proto::PropertyTree& proto) {
DCHECK_GT(proto.nodes_size(), 0);
nodes_.back().FromProtobuf(proto.nodes(0));
+ DCHECK(!node_id_to_index_map || (*node_id_to_index_map).empty());
for (int i = 1; i < proto.nodes_size(); ++i) {
nodes_.push_back(T());
nodes_.back().FromProtobuf(proto.nodes(i));
+ (*node_id_to_index_map)[nodes_.back().owner_id] = nodes_.back().id;
}
needs_update_ = proto.needs_update();
@@ -1281,11 +1285,13 @@ void TransformTree::ToProtobuf(proto::PropertyTree* proto) const {
data->add_nodes_affected_by_outer_viewport_bounds_delta(i);
}
-void TransformTree::FromProtobuf(const proto::PropertyTree& proto) {
+void TransformTree::FromProtobuf(
+ const proto::PropertyTree& proto,
+ std::unordered_map<int, int>* node_id_to_index_map) {
DCHECK(proto.has_property_type());
DCHECK_EQ(proto.property_type(), proto::PropertyTree::Transform);
- PropertyTree::FromProtobuf(proto);
+ PropertyTree::FromProtobuf(proto, node_id_to_index_map);
const proto::TransformTreeData& data = proto.transform_tree_data();
source_to_parent_updates_allowed_ = data.source_to_parent_updates_allowed();
@@ -1459,11 +1465,13 @@ void ClipTree::ToProtobuf(proto::PropertyTree* proto) const {
PropertyTree::ToProtobuf(proto);
}
-void ClipTree::FromProtobuf(const proto::PropertyTree& proto) {
+void ClipTree::FromProtobuf(
+ const proto::PropertyTree& proto,
+ std::unordered_map<int, int>* node_id_to_index_map) {
DCHECK(proto.has_property_type());
DCHECK_EQ(proto.property_type(), proto::PropertyTree::Clip);
- PropertyTree::FromProtobuf(proto);
+ PropertyTree::FromProtobuf(proto, node_id_to_index_map);
}
bool EffectTree::operator==(const EffectTree& other) const {
@@ -1477,11 +1485,13 @@ void EffectTree::ToProtobuf(proto::PropertyTree* proto) const {
PropertyTree::ToProtobuf(proto);
}
-void EffectTree::FromProtobuf(const proto::PropertyTree& proto) {
+void EffectTree::FromProtobuf(
+ const proto::PropertyTree& proto,
+ std::unordered_map<int, int>* node_id_to_index_map) {
DCHECK(proto.has_property_type());
DCHECK_EQ(proto.property_type(), proto::PropertyTree::Effect);
- PropertyTree::FromProtobuf(proto);
+ PropertyTree::FromProtobuf(proto, node_id_to_index_map);
}
ScrollTree::ScrollTree()
@@ -1546,11 +1556,13 @@ void ScrollTree::ToProtobuf(proto::PropertyTree* proto) const {
}
}
-void ScrollTree::FromProtobuf(const proto::PropertyTree& proto) {
+void ScrollTree::FromProtobuf(
+ const proto::PropertyTree& proto,
+ std::unordered_map<int, int>* node_id_to_index_map) {
DCHECK(proto.has_property_type());
DCHECK_EQ(proto.property_type(), proto::PropertyTree::Scroll);
- PropertyTree::FromProtobuf(proto);
+ PropertyTree::FromProtobuf(proto, node_id_to_index_map);
const proto::ScrollTreeData& data = proto.scroll_tree_data();
currently_scrolling_node_id_ = data.currently_scrolling_node_id();
@@ -1910,6 +1922,10 @@ bool PropertyTrees::operator==(const PropertyTrees& other) const {
return transform_tree == other.transform_tree &&
effect_tree == other.effect_tree && clip_tree == other.clip_tree &&
scroll_tree == other.scroll_tree &&
+ transform_id_to_index_map == other.transform_id_to_index_map &&
+ effect_id_to_index_map == other.effect_id_to_index_map &&
+ clip_id_to_index_map == other.clip_id_to_index_map &&
+ scroll_id_to_index_map == other.scroll_id_to_index_map &&
needs_rebuild == other.needs_rebuild && changed == other.changed &&
full_tree_damaged == other.full_tree_damaged &&
is_main_thread == other.is_main_thread &&
@@ -1923,6 +1939,10 @@ PropertyTrees& PropertyTrees::operator=(const PropertyTrees& from) {
effect_tree = from.effect_tree;
clip_tree = from.clip_tree;
scroll_tree = from.scroll_tree;
+ transform_id_to_index_map = from.transform_id_to_index_map;
+ effect_id_to_index_map = from.effect_id_to_index_map;
+ clip_id_to_index_map = from.clip_id_to_index_map;
+ scroll_id_to_index_map = from.scroll_id_to_index_map;
needs_rebuild = from.needs_rebuild;
changed = from.changed;
full_tree_damaged = from.full_tree_damaged;
@@ -1964,10 +1984,11 @@ void PropertyTrees::ToProtobuf(proto::PropertyTrees* proto) const {
// static
void PropertyTrees::FromProtobuf(const proto::PropertyTrees& proto) {
- transform_tree.FromProtobuf(proto.transform_tree());
- effect_tree.FromProtobuf(proto.effect_tree());
- clip_tree.FromProtobuf(proto.clip_tree());
- scroll_tree.FromProtobuf(proto.scroll_tree());
+ transform_tree.FromProtobuf(proto.transform_tree(),
+ &transform_id_to_index_map);
+ effect_tree.FromProtobuf(proto.effect_tree(), &effect_id_to_index_map);
+ clip_tree.FromProtobuf(proto.clip_tree(), &clip_id_to_index_map);
+ scroll_tree.FromProtobuf(proto.scroll_tree(), &scroll_id_to_index_map);
needs_rebuild = proto.needs_rebuild();
changed = proto.changed();
« no previous file with comments | « cc/trees/property_tree.h ('k') | cc/trees/property_tree_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698