Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1975603002: Add one benchmark to get CPU and memory usage without MR. (Closed)

Created:
4 years, 7 months ago by Lei Lei
Modified:
4 years, 7 months ago
Reviewers:
imcheng, apacible
CC:
chromium-reviews, media-router+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add one benchmark to get CPU and memory usage without MR. BUG=594225 Committed: https://crrev.com/cf85acfd343c7a02c9be08b6903f5290568fa26e Cr-Commit-Position: refs/heads/master@{#393408}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed Derek's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -6 lines) Patch
M chrome/test/media_router/telemetry/benchmarks/media_router_benchmark.py View 1 4 chunks +32 lines, -0 lines 0 comments Download
M chrome/test/media_router/telemetry/benchmarks/media_router_cpu_memory_metric.py View 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/test/media_router/telemetry/benchmarks/pagesets/media_router_perf_pages.py View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Lei Lei
4 years, 7 months ago (2016-05-12 00:19:36 UTC) #2
imcheng
https://codereview.chromium.org/1975603002/diff/1/chrome/test/media_router/telemetry/benchmarks/media_router_benchmark.py File chrome/test/media_router/telemetry/benchmarks/media_router_benchmark.py (right): https://codereview.chromium.org/1975603002/diff/1/chrome/test/media_router/telemetry/benchmarks/media_router_benchmark.py#newcode108 chrome/test/media_router/telemetry/benchmarks/media_router_benchmark.py:108: '--load-extension=' + 1) we don't need to load the ...
4 years, 7 months ago (2016-05-12 20:57:08 UTC) #3
Lei Lei
https://codereview.chromium.org/1975603002/diff/1/chrome/test/media_router/telemetry/benchmarks/media_router_benchmark.py File chrome/test/media_router/telemetry/benchmarks/media_router_benchmark.py (right): https://codereview.chromium.org/1975603002/diff/1/chrome/test/media_router/telemetry/benchmarks/media_router_benchmark.py#newcode108 chrome/test/media_router/telemetry/benchmarks/media_router_benchmark.py:108: '--load-extension=' + On 2016/05/12 20:57:08, imcheng wrote: > 1) ...
4 years, 7 months ago (2016-05-12 21:07:14 UTC) #4
imcheng
lgtm Thanks!
4 years, 7 months ago (2016-05-12 21:09:39 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975603002/20001
4 years, 7 months ago (2016-05-12 21:41:18 UTC) #7
apacible
lgtm
4 years, 7 months ago (2016-05-12 21:51:53 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-12 22:33:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975603002/20001
4 years, 7 months ago (2016-05-13 00:20:36 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-13 00:24:19 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 00:25:27 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cf85acfd343c7a02c9be08b6903f5290568fa26e
Cr-Commit-Position: refs/heads/master@{#393408}

Powered by Google App Engine
This is Rietveld 408576698