Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1975593003: Run queued tasks before shutting down after running a layout test. (Closed)

Created:
4 years, 7 months ago by Sam McNally
Modified:
4 years, 7 months ago
Reviewers:
Mike West
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run queued tasks before shutting down after running a layout test. Currently, when a layout test run finishes, the BlinkTestController falls out of scope, which triggers shutdown of the RenderProcessHostImpl used by the test. However, RenderProcessHostImpl posts a task to delete itself, which is currently never run; this results in a RenderProcessHostImpl outliving the UI MessageLoop and its BrowserContext, inviting use-after-frees. This CL fixes this issue by running queued tasks before shutting down the main runner. BUG=610989 Committed: https://crrev.com/d8514447d66180f24e25713aea4445f80a9f4d6e Cr-Commit-Position: refs/heads/master@{#393204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/shell/browser/layout_test/layout_test_browser_main.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Sam McNally
4 years, 7 months ago (2016-05-12 00:29:02 UTC) #3
Mike West
lgtm
4 years, 7 months ago (2016-05-12 05:39:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975593003/1
4 years, 7 months ago (2016-05-12 06:29:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 07:54:16 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 07:56:00 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8514447d66180f24e25713aea4445f80a9f4d6e
Cr-Commit-Position: refs/heads/master@{#393204}

Powered by Google App Engine
This is Rietveld 408576698