Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 1975583002: [MD settings] i18n-content to $i18n switch in the settings menu (Closed)

Created:
4 years, 7 months ago by dschuyler
Modified:
4 years, 7 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] i18n-content to $i18n switch in the settings menu This is a mechanical change from using i18n-content to using $i18n replacements in the settings menu (the side nav). BUG=611188 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/23ecf06e5064f55c9f0e93306b82fd1edb58ba2a Cr-Commit-Position: refs/heads/master@{#393145}

Patch Set 1 : icon fix #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -21 lines) Patch
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 2 chunks +20 lines, -21 lines 2 comments Download

Messages

Total messages: 11 (5 generated)
dschuyler
4 years, 7 months ago (2016-05-12 00:05:04 UTC) #4
tommycli
lgtm sans below https://codereview.chromium.org/1975583002/diff/20001/chrome/browser/resources/settings/settings_menu/settings_menu.html File chrome/browser/resources/settings/settings_menu/settings_menu.html (right): https://codereview.chromium.org/1975583002/diff/20001/chrome/browser/resources/settings/settings_menu/settings_menu.html#newcode118 chrome/browser/resources/settings/settings_menu/settings_menu.html:118: <span>$i18n{advancedPageTitle}</span> Is this span still needed?
4 years, 7 months ago (2016-05-12 00:06:30 UTC) #5
dschuyler
https://codereview.chromium.org/1975583002/diff/20001/chrome/browser/resources/settings/settings_menu/settings_menu.html File chrome/browser/resources/settings/settings_menu/settings_menu.html (right): https://codereview.chromium.org/1975583002/diff/20001/chrome/browser/resources/settings/settings_menu/settings_menu.html#newcode118 chrome/browser/resources/settings/settings_menu/settings_menu.html:118: <span>$i18n{advancedPageTitle}</span> On 2016/05/12 00:06:30, tommycli wrote: > Is this ...
4 years, 7 months ago (2016-05-12 00:09:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975583002/20001
4 years, 7 months ago (2016-05-12 01:22:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-12 02:02:51 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 02:06:28 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23ecf06e5064f55c9f0e93306b82fd1edb58ba2a
Cr-Commit-Position: refs/heads/master@{#393145}

Powered by Google App Engine
This is Rietveld 408576698