Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1975573002: [MD settings] i18n-content to $i18n switch in Site Settings (Closed)

Created:
4 years, 7 months ago by dschuyler
Modified:
4 years, 7 months ago
Reviewers:
Finnur
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] i18n-content to $i18n switch in Site Settings This CL changes i18n-content replacement to use $i18n replacement in the Site Settings. BUG=611188 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c97db9d9be3357388972d78004a7ce04c5004272 Cr-Commit-Position: refs/heads/master@{#393284}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/resources/settings/site_settings/site_details.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_settings_category.html View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dschuyler
4 years, 7 months ago (2016-05-11 23:55:51 UTC) #3
Finnur
LGTM, thanks.
4 years, 7 months ago (2016-05-12 15:16:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975573002/1
4 years, 7 months ago (2016-05-12 17:10:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 17:30:49 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 17:32:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c97db9d9be3357388972d78004a7ce04c5004272
Cr-Commit-Position: refs/heads/master@{#393284}

Powered by Google App Engine
This is Rietveld 408576698