content/browser/web_contents/web_contents_view_aura_browsertest.cc - Issue 1975533002: Change ui::Event::time_stamp from TimeDelta to TimeTicks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view_aura_browsertest.cc

Issue 1975533002: Change ui::Event::time_stamp from TimeDelta to TimeTicks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/web_input_event_aurawin.cc ('k') | content/common/input/synthetic_web_input_event_builders.h » ('j') | ui/views/controls/menu/menu_runner_cocoa_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_view_aura_browsertest.cc

diff --git a/content/browser/web_contents/web_contents_view_aura_browsertest.cc b/content/browser/web_contents/web_contents_view_aura_browsertest.cc

index a06161ba28449e11acec42abe9d43cbc70545979..247b7bc06ca84a4347df3a23082169145ebb002f 100644

--- a/content/browser/web_contents/web_contents_view_aura_browsertest.cc

+++ b/content/browser/web_contents/web_contents_view_aura_browsertest.cc

@@ -499,7 +499,7 @@ IN_PROC_BROWSER_TEST_F(WebContentsViewAuraTest,

ui::EventProcessor* dispatcher = content->GetHost()->event_processor();

gfx::Rect bounds = content->GetBoundsInRootWindow();

- base::TimeDelta timestamp = ui::EventTimeForNow();

+ base::TimeTicks timestamp = ui::EventTimeForNow();

ui::TouchEvent press(

ui::ET_TOUCH_PRESSED,

gfx::Point(bounds.x() + bounds.width() / 2, bounds.y() + 5), 0,

@@ -1032,7 +1032,7 @@ IN_PROC_BROWSER_TEST_F(WebContentsViewAuraTest, MAYBE_VerticalOverscroll) {

{

int kXStep = bounds.width() / 10;

gfx::Point location(bounds.right() - kXStep, bounds.y() + 5);

- base::TimeDelta timestamp = ui::EventTimeForNow();

+ base::TimeTicks timestamp = ui::EventTimeForNow();

ui::TouchEvent press(ui::ET_TOUCH_PRESSED, location, 0, timestamp);

ui::EventDispatchDetails details = dispatcher->OnEventFromSource(&press);

ASSERT_FALSE(details.dispatcher_destroyed);

@@ -1064,7 +1064,7 @@ IN_PROC_BROWSER_TEST_F(WebContentsViewAuraTest, MAYBE_VerticalOverscroll) {

int kYStep = bounds.height() / 10;

gfx::Point location(bounds.x() + 10, bounds.y() + kYStep);

- base::TimeDelta timestamp = ui::EventTimeForNow();

+ base::TimeTicks timestamp = ui::EventTimeForNow();

ui::TouchEvent press(ui::ET_TOUCH_PRESSED, location, 0, timestamp);

ui::EventDispatchDetails details = dispatcher->OnEventFromSource(&press);

ASSERT_FALSE(details.dispatcher_destroyed);

@@ -1098,7 +1098,7 @@ IN_PROC_BROWSER_TEST_F(WebContentsViewAuraTest, MAYBE_VerticalOverscroll) {

int kXStep = bounds.width() / 10;

int kYStep = bounds.height() / 10;

gfx::Point location = bounds.origin() + gfx::Vector2d(0, kYStep);

- base::TimeDelta timestamp = ui::EventTimeForNow();

+ base::TimeTicks timestamp = ui::EventTimeForNow();

ui::TouchEvent press(ui::ET_TOUCH_PRESSED, location, 0, timestamp);

ui::EventDispatchDetails details = dispatcher->OnEventFromSource(&press);

ASSERT_FALSE(details.dispatcher_destroyed);