Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: ash/shelf/shelf_view.cc

Issue 1975533002: Change ui::Event::time_stamp from TimeDelta to TimeTicks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix gesture recognizer tests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shelf/shelf_view.cc
diff --git a/ash/shelf/shelf_view.cc b/ash/shelf/shelf_view.cc
index d59ff70ae5017f478bb676ccea6c496387cdf5de..a90acf03d916f912b708ea765d9efc1ac8d33147 100644
--- a/ash/shelf/shelf_view.cc
+++ b/ash/shelf/shelf_view.cc
@@ -1873,7 +1873,7 @@ bool ShelfView::IsRepostEvent(const ui::Event& event) {
return false;
base::TimeDelta delta =
- base::TimeDelta(event.time_stamp() - closing_event_time_);
+ (event.time_stamp() - closing_event_time_) - base::TimeTicks();
closing_event_time_ = base::TimeDelta();
miu 2016/05/16 20:05:35 IIUC, closing_event_time_ needs to be changed to b
majidvp 2016/05/21 01:38:00 It should be eventually but I prefer to make that
// If the current (press down) event is a repost event, the time stamp of
// these two events should be the same.

Powered by Google App Engine
This is Rietveld 408576698