Change ui::Event::time_stamp from TimeDelta to TimeTicks

ui/events/cocoa/events_mac.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/events/event_utils.h"
 
 #include <Cocoa/Cocoa.h>
 #include <stdint.h>
 
 #include "base/logging.h"
 #import "base/mac/mac_util.h"
 #import "base/mac/sdk_forward_declarations.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
+#include "ui/events/base_event_utils.h"
 #include "ui/events/cocoa/cocoa_event_utils.h"
 #include "ui/events/event_utils.h"
+

[miu, 2016/05/16 20:05:35]

Please remove blank line here.

[majidvp, 2016/05/21 01:38:00]

Done.

 #import "ui/events/keycodes/keyboard_code_conversion_mac.h"
 #include "ui/gfx/geometry/point.h"
 #include "ui/gfx/geometry/vector2d.h"
 
 namespace ui {
 
 EventType EventTypeFromNative(const base::NativeEvent& native_event) {
   NSEventType type = [native_event type];
   switch (type) {
     case NSKeyDown:
@@ skipping 43 matching lines @@
       break;
   }
   return ET_UNKNOWN;
 }
 
 int EventFlagsFromNative(const base::NativeEvent& event) {
   NSUInteger modifiers = [event modifierFlags];
   return EventFlagsFromNSEventWithModifiers(event, modifiers);
 }
 
-base::TimeDelta EventTimeFromNative(const base::NativeEvent& native_event) {
+base::TimeTicks EventTimeFromNative(const base::NativeEvent& native_event) {
   NSTimeInterval since_system_startup = [native_event timestamp];
   // Truncate to extract seconds before doing floating point arithmetic.
   int64_t seconds = since_system_startup;
   since_system_startup -= seconds;
   int64_t microseconds = since_system_startup * 1000000;
-  return base::TimeDelta::FromSeconds(seconds) +
-      base::TimeDelta::FromMicroseconds(microseconds);
+  return ui::EventTimeStampFromSeconds(seconds) +

[miu, 2016/05/16 20:05:35]

This feels brittle. How will you ensure this remains in-line with the
base/time/time_mac.mm implementation? Perhaps you should write a unit test (or
at least some DCHECKing) to ensure this translation is always correct?

[majidvp, 2016/05/21 01:38:00]

Good point. I added a DCHECK to ensure it is within a reasonable distance of
TimeTicks::Now.

Note that we already track this in UMA and it is pretty clear that we should
never hit that DCHECK on Mac OS:
https://uma.googleplex.com/p/chrome/histograms/?endDate=05-18-2016&dayCount=2...
 

Also will look into how I can get Mac OS to generate event for testing purpose
and see if I can write a test for that.

+         base::TimeDelta::FromMicroseconds(microseconds);
 }
 
 gfx::Point EventLocationFromNative(const base::NativeEvent& native_event) {
   NSWindow* window = [native_event window];
   if (!window) {
     NOTIMPLEMENTED();  // Point will be in screen coordinates.
     return gfx::Point();
   }
   NSPoint location = [native_event locationInWindow];
   NSRect content_rect = [window contentRectForFrameRect:[window frame]];
@@ skipping 160 matching lines @@
   uint16_t return_value;
   [text getCharacters:&return_value];
   return return_value;
 }
 
 bool IsCharFromNative(const base::NativeEvent& native_event) {
   return false;
 }
 
 }  // namespace ui