Issue 197553009: Fix gcl try after PRESUBMIT files have been modified for multiple tryserver support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 197553009: Fix gcl try after PRESUBMIT files have been modified for multiple tryserver support (Closed)

Created:
6 years, 9 months ago by Paweł Hajdan Jr.

Modified:
6 years, 9 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Fix gcl try after PRESUBMIT files have been modified for multiple tryserver support Note that other waterfalls are not guaranteed to support triggering via HTTP or SVN. That's why this hardcodes tryserver.chromium. BUG=334892 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=256947

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	trychange.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

The CQ bit was checked by phajdan.jr@chromium.org

6 years, 9 months ago (2014-03-13 22:23:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/197553009/1

6 years, 9 months ago (2014-03-13 22:24:05 UTC) #4

agable

6 years, 9 months ago (2014-03-17 19:04:28 UTC) #6

Message was sent while issue was closed.

On 2014/03/13 22:25:54, I haz the power (commit-bot) wrote:
> Change committed as 256947

This broke NACL, as they use git-try to send tryjobs to master.tryserver.nacl
via committing patches to svn://svn.chromium.org/chrome-try/try-nacl. This code
discards the bots they set on tryserver.nacl, resulting in all of their jobs
having the empty set for which bots to run, resulting in their jobs being run on
all the bots.

Expand Messages | Collapse Messages