Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 197553002: Revert of Revert of Revert "De-virtualize SkCanvas save/restore." (Closed)

Created:
6 years, 9 months ago by fmalita_google_do_not_use
Modified:
6 years, 9 months ago
Reviewers:
hal.canary, f(malita)
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert of Revert of Revert "De-virtualize SkCanvas save/restore." (https://codereview.chromium.org/196323003/) Reason for revert: Pulling out to rename the virtuals. Original issue's description: > Revert of Revert "De-virtualize SkCanvas save/restore." (https://codereview.chromium.org/194923008/) > > Reason for revert: > Re-landing after roll fix. > > Original issue's description: > > Revert "De-virtualize SkCanvas save/restore." > > > > (To allow a roll fix into the tree). > > > > This reverts commit edf702204be42c945254191f9f9cd6585b3d189b. > > > > R=halcanary@google.com > > > > Committed: https://code.google.com/p/skia/source/detail?r=13748 > > TBR=halcanary@google.com,fmalita@chromium.org > NOTREECHECKS=true > NOTRY=true > > Committed: http://code.google.com/p/skia/source/detail?r=13754 TBR=halcanary@google.com,fmalita@chromium.org NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=13765

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -204 lines) Patch
M experimental/PdfViewer/SkNulCanvas.h View 2 chunks +7 lines, -6 lines 0 comments Download
M include/core/SkCanvas.h View 5 chunks +5 lines, -13 lines 0 comments Download
M include/utils/SkDeferredCanvas.h View 2 chunks +4 lines, -4 lines 0 comments Download
M include/utils/SkDumpCanvas.h View 2 chunks +5 lines, -4 lines 0 comments Download
M include/utils/SkLuaCanvas.h View 2 chunks +5 lines, -4 lines 0 comments Download
M include/utils/SkNWayCanvas.h View 2 chunks +4 lines, -4 lines 0 comments Download
M include/utils/SkProxyCanvas.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/core/SkBBoxHierarchyRecord.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/core/SkBBoxHierarchyRecord.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M src/core/SkCanvas.cpp View 6 chunks +3 lines, -25 lines 0 comments Download
M src/core/SkPictureRecord.h View 2 chunks +3 lines, -5 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 6 chunks +15 lines, -13 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 4 chunks +18 lines, -21 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 chunk +19 lines, -16 lines 0 comments Download
M src/utils/SkDumpCanvas.cpp View 2 chunks +11 lines, -11 lines 0 comments Download
M src/utils/SkLuaCanvas.cpp View 2 chunks +11 lines, -14 lines 0 comments Download
M src/utils/SkNWayCanvas.cpp View 1 chunk +11 lines, -15 lines 0 comments Download
M src/utils/SkNoSaveLayerCanvas.h View 1 chunk +13 lines, -5 lines 0 comments Download
M src/utils/SkProxyCanvas.cpp View 1 chunk +6 lines, -11 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 2 chunks +6 lines, -4 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 2 chunks +11 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
fmalita_google_do_not_use
Created Revert of Revert of Revert "De-virtualize SkCanvas save/restore."
6 years, 9 months ago (2014-03-12 15:07:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@google.com/197553002/1
6 years, 9 months ago (2014-03-12 15:08:01 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 15:08:29 UTC) #3
Message was sent while issue was closed.
Change committed as 13765

Powered by Google App Engine
This is Rietveld 408576698