Chromium Code Reviews
DescriptionRevert of Set hard_dependency for media and media_features gyp targets (patchset #2 id:20001 of https://codereview.chromium.org/1969493002/ )
Reason for revert:
Appears to cause Windows builds to fail.
https://build.chromium.org/p/chromium/builders/Win/builds/43308
Please fix and reland
Original issue's description:
> Set hard_dependency for media and media_features gyp targets
>
> The media_features gyp target generates a header that is included by
> many other files indirectly through media/base/video_codecs.h, so
> both the main media target and media_features target must be marked
> as hard_dependency: 1, to ensure the media_features.h header is
> generated before being used anywhere.
>
> BUG=606829
>
> Committed: https://crrev.com/1652fefd7f5c0d7da557d26a0a107ed2acc25c31
> Cr-Commit-Position: refs/heads/master@{#393049}
TBR=wolenetz@chromium.org,brettw@chromium.org,dpranke@chromium.org,servolk@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=606829
Committed: https://crrev.com/a50532323e28dc6f912c5655b20f2a7ece389b1c
Cr-Commit-Position: refs/heads/master@{#393064}
Patch Set 1 #
Messages
Total messages: 7 (2 generated)
|
|||||||||||||||||||