Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1975483002: Revert of Set hard_dependency for media and media_features gyp targets (Closed)

Created:
4 years, 7 months ago by ananta
Modified:
4 years, 7 months ago
CC:
stanisc, chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Set hard_dependency for media and media_features gyp targets (patchset #2 id:20001 of https://codereview.chromium.org/1969493002/ ) Reason for revert: Appears to cause Windows builds to fail. https://build.chromium.org/p/chromium/builders/Win/builds/43308 Please fix and reland Original issue's description: > Set hard_dependency for media and media_features gyp targets > > The media_features gyp target generates a header that is included by > many other files indirectly through media/base/video_codecs.h, so > both the main media target and media_features target must be marked > as hard_dependency: 1, to ensure the media_features.h header is > generated before being used anywhere. > > BUG=606829 > > Committed: https://crrev.com/1652fefd7f5c0d7da557d26a0a107ed2acc25c31 > Cr-Commit-Position: refs/heads/master@{#393049} TBR=wolenetz@chromium.org,brettw@chromium.org,dpranke@chromium.org,servolk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=606829 Committed: https://crrev.com/a50532323e28dc6f912c5655b20f2a7ece389b1c Cr-Commit-Position: refs/heads/master@{#393064}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M media/media.gyp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ananta
Created Revert of Set hard_dependency for media and media_features gyp targets
4 years, 7 months ago (2016-05-11 21:33:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975483002/1
4 years, 7 months ago (2016-05-11 21:34:04 UTC) #2
servolk
On 2016/05/11 21:33:11, ananta wrote: > Created Revert of Set hard_dependency for media and media_features ...
4 years, 7 months ago (2016-05-11 21:34:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 21:35:30 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 21:37:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a50532323e28dc6f912c5655b20f2a7ece389b1c
Cr-Commit-Position: refs/heads/master@{#393064}

Powered by Google App Engine
This is Rietveld 408576698