Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1975463002: Get the correct page size for linearized PDFs. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Wei Li
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get the correct page size for linearized PDFs. This is a reland of r391011, which was reverted because the new code path hit a PDFium bug. BUG=604146 Committed: https://crrev.com/8ad3c81f1ec4e67a71b17f7d97165c68a3c87d46 Cr-Commit-Position: refs/heads/master@{#393128}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M pdf/pdfium/pdfium_engine.cc View 2 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Lei Zhang
This is the same as https://codereview.chromium.org/1975463002/ I will land this after rolling DEPS for PDFium.
4 years, 7 months ago (2016-05-11 21:34:31 UTC) #3
Wei Li
lgtm
4 years, 7 months ago (2016-05-11 21:49:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975463002/1
4 years, 7 months ago (2016-05-11 23:23:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 01:12:02 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 01:14:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ad3c81f1ec4e67a71b17f7d97165c68a3c87d46
Cr-Commit-Position: refs/heads/master@{#393128}

Powered by Google App Engine
This is Rietveld 408576698