sdk/lib/_internal/compiler/implementation/compiler.dart - Issue 19754002: Rewrite how we handle synthesized constructors in the compiler. This was motivated by issue https:/…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/compiler.dart

Issue 19754002: Rewrite how we handle synthesized constructors in the compiler. This was motivated by issue https:/… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/compile_time_constants.dart ('k') | sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart » ('j') | sdk/lib/_internal/compiler/implementation/deferred_load.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/compiler.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/compiler.dart (revision 25107)

+++ sdk/lib/_internal/compiler/implementation/compiler.dart (working copy)

@@ -1048,15 +1048,14 @@

TreeElements analyzeElement(Element element) {

assert(invariant(element, element.isDeclaration));

- assert(!element.isForwardingConstructor);

ResolutionEnqueuer world = enqueuer.resolution;

TreeElements elements = world.getCachedElements(element);

if (elements != null) return elements;

assert(parser != null);

Node tree = parser.parse(element);

- validator.validate(tree);

+ if (tree != null) validator.validate(tree);

ahe 2013/07/18 14:32:56 assert(invariant(element, !element.isSynthetic ||

ngeoffray 2013/07/18 15:25:14 Done.

elements = resolver.resolve(element);

- if (elements != null && !analyzeSignaturesOnly) {

+ if (tree != null && elements != null && !analyzeSignaturesOnly) {

// Only analyze nodes with a corresponding [TreeElements].

checker.check(elements);

}