Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1975393003: gn: Mention complete_static_lib in `gn help static_library`. (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Mention complete_static_lib in `gn help static_library`. BUG=none Committed: https://crrev.com/4f380b7cbb12e5ce75960857e9f8490f86cbdf9d Cr-Commit-Position: refs/heads/master@{#393681}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/gn/functions_target.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Nico
like so?
4 years, 7 months ago (2016-05-13 22:09:49 UTC) #3
Dirk Pranke
lgtm !
4 years, 7 months ago (2016-05-13 22:12:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975393003/1
4 years, 7 months ago (2016-05-13 22:13:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 23:18:34 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 23:19:45 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4f380b7cbb12e5ce75960857e9f8490f86cbdf9d
Cr-Commit-Position: refs/heads/master@{#393681}

Powered by Google App Engine
This is Rietveld 408576698