Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1975383002: Verify that required param constants are accessible outside the declaring lib (#26440). (Closed)

Created:
4 years, 7 months ago by pquitslund
Modified:
4 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Verify that required param constants are accessible outside the declaring lib (#26440). A test to verify that `required` "details" are accessible in reporting errors found outside of the declaring library. Follows up on Brian's fix: https://github.com/dart-lang/sdk/commit/23b02bc35112ebb955e006b87b3fbe03c5e071d7. More context: https://github.com/dart-lang/sdk/issues/26440. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/e1fad5cddbbf23cf3c6c4592d76e0654171f0f3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 3 chunks +25 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
4 years, 7 months ago (2016-05-13 21:11:14 UTC) #2
Brian Wilkerson
lgtm
4 years, 7 months ago (2016-05-13 21:30:25 UTC) #3
pquitslund
4 years, 7 months ago (2016-05-13 21:31:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e1fad5cddbbf23cf3c6c4592d76e0654171f0f3a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698