third_party/WebKit/Source/core/fetch/ResourceFetcher.h - Issue 1975373002: Clean up response handling in ResourceLoader/ResourceFetcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcher.h

Issue 1975373002: Clean up response handling in ResourceLoader/ResourceFetcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Back to ResourceError:cancelledDueToAccessCheckError Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-none-expected.txt ('k') | third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/ResourceFetcher.h

diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcher.h b/third_party/WebKit/Source/core/fetch/ResourceFetcher.h

index a72bed845e10160b84e5b8a5217a7a40288300e5..5f05087fed4e89ef5aea3ad1d75289f9bca3d9c7 100644

--- a/third_party/WebKit/Source/core/fetch/ResourceFetcher.h

+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcher.h

@@ -114,12 +114,10 @@ public:

};

void didFinishLoading(Resource*, double finishTime, int64_t encodedDataLength, DidFinishLoadingReason);

void didFailLoading(Resource*, const ResourceError&);

- void didReceiveResponse(Resource*, const ResourceResponse&);

+ void didReceiveResponse(Resource*, const ResourceResponse&, WebDataConsumerHandle*);

void didReceiveData(const Resource*, const char* data, int dataLength, int encodedDataLength);

void didDownloadData(const Resource*, int dataLength, int encodedDataLength);

bool defersLoading() const;

- bool canAccessResource(Resource*, SecurityOrigin*, const KURL&) const;

bool isControlledByServiceWorker() const;

void acceptDataFromThreadedReceiver(unsigned long identifier, const char* data, int dataLength, int encodedDataLength);

@@ -166,6 +164,7 @@ private:

void initializeResourceRequest(ResourceRequest&, Resource::Type, FetchRequest::DeferOption);

void willSendRequest(unsigned long identifier, ResourceRequest&, const ResourceResponse&, const ResourceLoaderOptions&);

+ bool canAccessResponse(Resource*, const ResourceResponse&) const;

bool resourceNeedsLoad(Resource*, const FetchRequest&, RevalidationPolicy);

bool shouldDeferImageLoad(const KURL&) const;