Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcher.h

Issue 1975373002: Clean up response handling in ResourceLoader/ResourceFetcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ResourceFetcher.h
diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcher.h b/third_party/WebKit/Source/core/fetch/ResourceFetcher.h
index 7b61b9700a3fddc4cdac798b7a195a025e23f8ac..205c31e46b19a40e8d409b423d1a3aa63c05fc07 100644
--- a/third_party/WebKit/Source/core/fetch/ResourceFetcher.h
+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcher.h
@@ -114,16 +114,10 @@ public:
};
void didFinishLoading(Resource*, double finishTime, int64_t encodedDataLength, DidFinishLoadingReason);
void didFailLoading(Resource*, const ResourceError&);
- void didReceiveResponse(Resource*, const ResourceResponse&);
+ bool didReceiveResponse(Resource*, const ResourceResponse&);
hiroshige 2016/07/28 09:56:42 It is important to check the return value of this
Nate Chapin 2016/07/28 22:29:35 Refactored so that this returns void again.
void didReceiveData(const Resource*, const char* data, int dataLength, int encodedDataLength);
void didDownloadData(const Resource*, int dataLength, int encodedDataLength);
bool defersLoading() const;
-
- enum AccessControlLoggingDecision {
- ShouldLogAccessControlErrors,
- ShouldNotLogAccessControlErrors
- };
- bool canAccessResource(Resource*, SecurityOrigin*, const KURL&, AccessControlLoggingDecision) const;
bool isControlledByServiceWorker() const;
void acceptDataFromThreadedReceiver(unsigned long identifier, const char* data, int dataLength, int encodedDataLength);
@@ -170,6 +164,7 @@ private:
void initializeResourceRequest(ResourceRequest&, Resource::Type, FetchRequest::DeferOption);
void willSendRequest(unsigned long identifier, ResourceRequest&, const ResourceResponse&, const ResourceLoaderOptions&);
+ bool canAccessResponse(Resource*, const ResourceResponse&) const;
bool resourceNeedsLoad(Resource*, const FetchRequest&, RevalidationPolicy);
bool shouldDeferImageLoad(const KURL&) const;

Powered by Google App Engine
This is Rietveld 408576698