Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1975363002: Add ThreadChecker for V8SamplingProfiler. (Closed)

Created:
4 years, 7 months ago by lpy
Modified:
4 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, devtools-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ThreadChecker for V8SamplingProfiler. V8SamplingProfiler is now a subclass of AsyncEnabledStateObserver, this patch adds a ThreadChecker in V8SamplingProfiler to ensure it gets called in the right thread. BUG=611027 Committed: https://crrev.com/a8aadea34d0be53e35e32ab882fb675e7307d8a7 Cr-Commit-Position: refs/heads/master@{#393698}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/renderer/devtools/v8_sampling_profiler.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/devtools/v8_sampling_profiler.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
lpy
PTAL.
4 years, 7 months ago (2016-05-13 20:54:05 UTC) #2
alph
lgtm
4 years, 7 months ago (2016-05-13 21:24:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975363002/1
4 years, 7 months ago (2016-05-13 21:24:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/147935)
4 years, 7 months ago (2016-05-13 22:05:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975363002/20001
4 years, 7 months ago (2016-05-14 00:04:21 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-14 00:10:51 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-14 00:12:48 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a8aadea34d0be53e35e32ab882fb675e7307d8a7
Cr-Commit-Position: refs/heads/master@{#393698}

Powered by Google App Engine
This is Rietveld 408576698