Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 197533009: Remove WebInspector.HeapSnapshotArraySlice (Closed)

Created:
6 years, 9 months ago by yurys
Modified:
6 years, 9 months ago
Reviewers:
alph, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Remove WebInspector.HeapSnapshotArraySlice This is exact copy of r169554 with a fix for inpsector protocol tests. Uin32Array already has subarray method that returns a new view for the same array buffer. BUG=None TBR=alph@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -74 lines) Patch
M LayoutTests/inspector-protocol/heap-profiler/resources/heap-snapshot-common.js View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot.html View 3 chunks +7 lines, -7 lines 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-test.js View 2 chunks +11 lines, -5 lines 0 comments Download
M Source/devtools/front_end/HeapSnapshot.js View 10 chunks +17 lines, -56 lines 0 comments Download
M Source/devtools/front_end/JSHeapSnapshot.js View 5 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
yurys
6 years, 9 months ago (2014-03-20 06:10:55 UTC) #1
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 9 months ago (2014-03-20 06:11:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/197533009/1
6 years, 9 months ago (2014-03-20 06:11:08 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 06:13:20 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-20 06:13:20 UTC) #5
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 9 months ago (2014-03-20 06:54:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/197533009/1
6 years, 9 months ago (2014-03-20 06:55:03 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 07:14:02 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-20 07:14:02 UTC) #9
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 9 months ago (2014-03-20 07:43:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/197533009/1
6 years, 9 months ago (2014-03-20 07:43:09 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 08:46:31 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-20 08:46:31 UTC) #13
yurys
Committed patchset #1 manually as r169639 (presubmit successful).
6 years, 9 months ago (2014-03-20 09:57:24 UTC) #14
alph
6 years, 9 months ago (2014-03-20 10:07:42 UTC) #15
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698