content/browser/web_contents/web_contents_view_guest.cc - Issue 197533008: Mac: ExternalPopupMenu::close should hide a showing popup menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view_guest.cc

Issue 197533008: Mac: ExternalPopupMenu::close should hide a showing popup menu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: test fix Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_view_guest.cc

diff --git a/content/browser/web_contents/web_contents_view_guest.cc b/content/browser/web_contents/web_contents_view_guest.cc

index 8fbc909521bcadac7484ca7289b53b8f94224724..cd25a9f8a44c688eb0c6ff09f90126c1d63bc28b 100644

--- a/content/browser/web_contents/web_contents_view_guest.cc

+++ b/content/browser/web_contents/web_contents_view_guest.cc

@@ -254,6 +254,11 @@ void WebContentsViewGuest::ShowPopupMenu(const gfx::Rect& bounds,

NOTIMPLEMENTED();

}

+void WebContentsViewGuest::HidePopupMenu() {

+ // External popup menus are only used on Mac and Android.

+ NOTIMPLEMENTED();

void WebContentsViewGuest::StartDragging(

const DropData& drop_data,

WebDragOperationsMask ops,