content/renderer/render_view_impl.cc - Issue 197533008: Mac: ExternalPopupMenu::close should hide a showing popup menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 197533008: Mac: ExternalPopupMenu::close should hide a showing popup menu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index 42bca241cd283508d1d2214bad08c14b153ad69c..535e15cdcd8b872d01f0267ff473ee0e28d06f40 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -4928,6 +4928,13 @@ void RenderViewImpl::OnSelectPopupMenuItems(

}

#endif

+void RenderViewImpl::DidHideExternalPopupMenu()

+ // We need to clear external_popup_menu_ as soon as ExternalPopupMenu::close

+ // is called. Otherwise, createExternalPopupMenu() for new popup will fail.

+ external_popup_menu_.reset();

void RenderViewImpl::OnShowContextMenu(const gfx::Point& location) {

context_menu_source_type_ = ui::MENU_SOURCE_TOUCH_EDIT_MENU;

touch_editing_context_menu_location_ = location;