Blimp Client: add support for tap gesture events

Client sends tapDown TapCancel TapUnconfirmed and showPress gesture events.

These events are used in content browser side gesture handling logic to update internal state or state machine, such as in render_widget_host_impl and tap_suppression_controller.

BUG=598876, 611590
Committed: https://crrev.com/d101e6286d62003088249577e5f931c335f6d060
Cr-Commit-Position: refs/heads/master@{#393933}

[haibinlu, 2016-05-13 23:23:59]

haibinlu@chromium.org changed reviewers:
+ khushalsagar@chromium.org

[haibinlu, 2016-05-13 23:30:10]

Description was changed from

==========
Client sends tapDown TapCancel TapUnconfirmed and showPress gensture events.

These events are used in content browser side gesture handling logic, such as in
render_widget_host_impl and tap_suppression_controller.

BUG=598876,611590
==========

to

==========
Client sends tapDown TapCancel TapUnconfirmed and showPress gesture events.

These events are used in content browser side gesture handling logic, such as in
render_widget_host_impl and tap_suppression_controller.

BUG=598876,611590
==========

[haibinlu, 2016-05-16 17:21:02]

haibinlu@chromium.org changed reviewers:
+ kmarshall@chromium.org

[Kevin M, 2016-05-16 18:31:32]

https://codereview.chromium.org/1975213003/diff/1/blimp/common/proto/input.proto
File blimp/common/proto/input.proto (right):

https://codereview.chromium.org/1975213003/diff/1/blimp/common/proto/input.pr...
blimp/common/proto/input.proto:96: optional int32 render_widget_id = 2;
Any reason why these are being renumbered?

https://codereview.chromium.org/1975213003/diff/1/blimp/engine/session/blimp_...
File blimp/engine/session/blimp_engine_session.cc (right):

https://codereview.chromium.org/1975213003/diff/1/blimp/engine/session/blimp_...
blimp/engine/session/blimp_engine_session.cc:392: DVLOG(2) <<
"OnWebGestureEvent: " << event->type;
As long as we are adding traces for this event, what about just pushing
event->type in as a trace ID?

https://codereview.chromium.org/1975213003/diff/1/blimp/net/input_message_gen...
File blimp/net/input_message_generator.cc (right):

https://codereview.chromium.org/1975213003/diff/1/blimp/net/input_message_gen...
blimp/net/input_message_generator.cc:217: NOTIMPLEMENTED();
In practice, this line has been really noisy on debug builds. I suggest that
this warning be turned into a DVLOG.

[Kevin M, 2016-05-16 18:33:51]

Also, re: CL description, add mention as to how this CL fixes the bug. The
subject line grammar can also be improved:

"Blimp Client: add support for tap gesture events."

[haibinlu, 2016-05-16 18:41:42]

PTAL

https://codereview.chromium.org/1975213003/diff/1/blimp/common/proto/input.proto
File blimp/common/proto/input.proto (right):

https://codereview.chromium.org/1975213003/diff/1/blimp/common/proto/input.pr...
blimp/common/proto/input.proto:96: optional int32 render_widget_id = 2;
On 2016/05/16 18:31:32, Kevin M wrote:
> Any reason why these are being renumbered?

per offline discussion, renumbering it is ok at current stage.

https://codereview.chromium.org/1975213003/diff/1/blimp/engine/session/blimp_...
File blimp/engine/session/blimp_engine_session.cc (right):

https://codereview.chromium.org/1975213003/diff/1/blimp/engine/session/blimp_...
blimp/engine/session/blimp_engine_session.cc:392: DVLOG(2) <<
"OnWebGestureEvent: " << event->type;
On 2016/05/16 18:31:32, Kevin M wrote:
> As long as we are adding traces for this event, what about just pushing
> event->type in as a trace ID?

but trace ID does not give a sequence of event types that lead to engine crash.

[haibinlu, 2016-05-16 18:57:14]

Description was changed from

==========
Client sends tapDown TapCancel TapUnconfirmed and showPress gesture events.

These events are used in content browser side gesture handling logic, such as in
render_widget_host_impl and tap_suppression_controller.

BUG=598876,611590
==========

to

==========
Client sends tapDown TapCancel TapUnconfirmed and showPress gesture events.

These events are used in content browser side gesture handling logic to update
internal state or state machine, such as in render_widget_host_impl and
tap_suppression_controller.

BUG=598876,611590
==========

[haibinlu, 2016-05-16 18:57:29]

https://codereview.chromium.org/1975213003/diff/1/blimp/engine/session/blimp_...
File blimp/engine/session/blimp_engine_session.cc (right):

https://codereview.chromium.org/1975213003/diff/1/blimp/engine/session/blimp_...
blimp/engine/session/blimp_engine_session.cc:392: DVLOG(2) <<
"OnWebGestureEvent: " << event->type;
On 2016/05/16 18:41:42, haibinlu wrote:
> On 2016/05/16 18:31:32, Kevin M wrote:
> > As long as we are adding traces for this event, what about just pushing
> > event->type in as a trace ID?
> 
> but trace ID does not give a sequence of event types that lead to engine
crash. 

done

[Khushal, 2016-05-16 19:17:29]

lgtm. Thanks Haibin!

[Kevin M, 2016-05-16 20:46:50]

lgtm

[haibinlu, 2016-05-16 20:48:51]

The CQ bit was checked by haibinlu@chromium.org

[haibinlu, 2016-05-16 20:48:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
kmarshall@chromium.org, khushalsagar@chromium.org
Link to the patchset: https://codereview.chromium.org/1975213003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-16 20:49:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1975213003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1975213003/60001

[commit-bot: I haz the power, 2016-05-16 21:30:33]

Description was changed from

==========
Client sends tapDown TapCancel TapUnconfirmed and showPress gesture events.

These events are used in content browser side gesture handling logic to update
internal state or state machine, such as in render_widget_host_impl and
tap_suppression_controller.

BUG=598876,611590
==========

to

==========
Client sends tapDown TapCancel TapUnconfirmed and showPress gesture events.

These events are used in content browser side gesture handling logic to update
internal state or state machine, such as in render_widget_host_impl and
tap_suppression_controller.

BUG=598876,611590
==========

[commit-bot: I haz the power, 2016-05-16 21:30:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-16 21:31:49]

Description was changed from

==========
Client sends tapDown TapCancel TapUnconfirmed and showPress gesture events.

These events are used in content browser side gesture handling logic to update
internal state or state machine, such as in render_widget_host_impl and
tap_suppression_controller.

BUG=598876,611590
==========

to

==========
Client sends tapDown TapCancel TapUnconfirmed and showPress gesture events.

These events are used in content browser side gesture handling logic to update
internal state or state machine, such as in render_widget_host_impl and
tap_suppression_controller.

BUG=598876,611590

Committed: https://crrev.com/d101e6286d62003088249577e5f931c335f6d060
Cr-Commit-Position: refs/heads/master@{#393933}
==========

[commit-bot: I haz the power, 2016-05-16 21:31:50]

Patchset 4 (id:??) landed as
https://crrev.com/d101e6286d62003088249577e5f931c335f6d060
Cr-Commit-Position: refs/heads/master@{#393933}