Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 1975203003: Cleanup timeline stream enabled flag so that it can be easily tested from an intrinsic (Closed)

Created:
4 years, 7 months ago by Cutch
Modified:
4 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cleanup timeline stream enabled flag so that it can be easily tested from an intrinsic - Drop no-longer used globally enabled stream flags. This leaves just one source of truth. - Kill 'Enabled()' for 'enabled()'. - Store pointer to Timeline::DartStream in Thread. - Store enabled as an uintptr_t instead of a bool to make it easier for generated code to access. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/d1d3ba587b0f177bf68eb5078e83de185ff3e57d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -61 lines) Patch
M runtime/vm/deopt_instructions.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/thread.h View 3 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/thread.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/timeline.h View 3 chunks +39 lines, -45 lines 0 comments Download
M runtime/vm/timeline.cc View 7 chunks +9 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
4 years, 7 months ago (2016-05-13 21:25:42 UTC) #3
rmacnak
lgtm
4 years, 7 months ago (2016-05-16 17:07:15 UTC) #4
Cutch
4 years, 7 months ago (2016-05-16 17:30:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d1d3ba587b0f177bf68eb5078e83de185ff3e57d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698