Use builders to convert between WebKit and content IDB types

Use builders to convert between WebKit and content IDB types

This uses a set of builder classes to convert between WebKit IDB types
and their content equivalents so that code that links against the WebKit
symbols can be restricted to child processes.

R=alecflett@chromium.org, jam@chromium.org
BUG=237267
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212715

[jamesr, 2013-07-18 21:31:16]

https://codereview.chromium.org/19752007/diff/1/content/child/indexed_db/inde...
File content/child/indexed_db/indexed_db_key_builders.h (right):

https://codereview.chromium.org/19752007/diff/1/content/child/indexed_db/inde...
content/child/indexed_db/indexed_db_key_builders.h:25: static WebKit::WebIDBKey
Build(const content::IndexedDBKey& key);
@darin - what do you think of this pattern?  It's similar to the builders you've
created for WebKit -> content conversions, but this code also needs to go
content -> WK sometimes.  This overrides on the parameter type to make the code
look consistent but is a bit funky.  Do you think this is OK?

[alecflett, 2013-07-18 21:39:10]

lgtm

yay!

[jamesr, 2013-07-19 02:32:03]

Hmm, some IndexedDB content_browsertests are failing on the trybots.  Will
investigate that before landing...

[darin (slow to review), 2013-07-19 04:12:08]

https://codereview.chromium.org/19752007/diff/8001/content/child/indexed_db/i...
File content/child/indexed_db/indexed_db_key_builders.h (right):

https://codereview.chromium.org/19752007/diff/8001/content/child/indexed_db/i...
content/child/indexed_db/indexed_db_key_builders.h:25: static WebKit::WebIDBKey
Build(const content::IndexedDBKey& key);
maybe this second one should be on a class named WebIDBKeyBuilder instead? 
since it builds a WebIDBKey?

[jamesr, 2013-07-19 04:45:41]

On 2013/07/19 04:12:08, darin wrote:
>
https://codereview.chromium.org/19752007/diff/8001/content/child/indexed_db/i...
> File content/child/indexed_db/indexed_db_key_builders.h (right):
> 
>
https://codereview.chromium.org/19752007/diff/8001/content/child/indexed_db/i...
> content/child/indexed_db/indexed_db_key_builders.h:25: static
WebKit::WebIDBKey
> Build(const content::IndexedDBKey& key);
> maybe this second one should be on a class named WebIDBKeyBuilder instead? 
> since it builds a WebIDBKey?

Hmm, sure.  It's more classes but the callsites are clearer.

The browser tests were failing due to the DCHECK(key_path.isValid()); in
IndexedDBKeyPathBuilder::Build().  No idea why this failed, but the old code
didn't check for this either.

[jam, 2013-07-19 22:00:08]

deps/gypi lgtm

[commit-bot: I haz the power, 2013-07-19 22:05:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/19752007/20001

[jamesr, 2013-07-20 01:44:48]

Committed patchset #4 manually as r212715 (presubmit successful).