Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: src/x64/assembler-x64.h

Issue 19752004: Add the emitp function for X64 assembler (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/x64/assembler-x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/x64/assembler-x64.h
===================================================================
--- src/x64/assembler-x64.h (revision 15744)
+++ src/x64/assembler-x64.h (working copy)
@@ -1443,8 +1443,8 @@
void GrowBuffer();
void emit(byte x) { *pc_++ = x; }
+ inline void emit(uintptr_t x, RelocInfo::Mode rmode);
danno 2013/07/23 12:40:54 why not call this emitp (i.e. for "pointer") and h
haitao.feng 2013/07/24 06:35:12 Done.
inline void emitl(uint32_t x);
- inline void emitq(uint64_t x, RelocInfo::Mode rmode);
danno 2013/07/23 12:40:54 I don't see a need to remove this. Please leave it
haitao.feng 2013/07/24 06:35:12 Done.
inline void emitw(uint16_t x);
inline void emit_code_target(Handle<Code> target,
RelocInfo::Mode rmode,
« no previous file with comments | « no previous file | src/x64/assembler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698