Add the emitp function for X64 assembler

Add the emitp function for X64 assembler

R=danno@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15861

[haitao.feng, 2013-07-18 13:15:58]

This is danno's comment on https://codereview.chromium.org/18014003.

[danno, 2013-07-23 12:40:54]

https://codereview.chromium.org/19752004/diff/1/src/x64/assembler-x64.h
File src/x64/assembler-x64.h (left):

https://codereview.chromium.org/19752004/diff/1/src/x64/assembler-x64.h#oldco...
src/x64/assembler-x64.h:1447: inline void emitq(uint64_t x, RelocInfo::Mode
rmode);
I don't see a need to remove this. Please leave it in and just add a new
function.

https://codereview.chromium.org/19752004/diff/1/src/x64/assembler-x64.h
File src/x64/assembler-x64.h (right):

https://codereview.chromium.org/19752004/diff/1/src/x64/assembler-x64.h#newco...
src/x64/assembler-x64.h:1446: inline void emit(uintptr_t x, RelocInfo::Mode
rmode);
why not call this emitp (i.e. for "pointer") and have it take a void* parameter?
I think that makes it clearer. Then some of the reinterpret_cast nastiness can
be hidden and centralized inside emitp.

[haitao.feng, 2013-07-24 06:35:12]

danno, thanks for the review.

https://codereview.chromium.org/19752004/diff/1/src/x64/assembler-x64.h
File src/x64/assembler-x64.h (left):

https://codereview.chromium.org/19752004/diff/1/src/x64/assembler-x64.h#oldco...
src/x64/assembler-x64.h:1447: inline void emitq(uint64_t x, RelocInfo::Mode
rmode);
On 2013/07/23 12:40:54, danno wrote:
> I don't see a need to remove this. Please leave it in and just add a new
> function.

Done.

https://codereview.chromium.org/19752004/diff/1/src/x64/assembler-x64.h
File src/x64/assembler-x64.h (right):

https://codereview.chromium.org/19752004/diff/1/src/x64/assembler-x64.h#newco...
src/x64/assembler-x64.h:1446: inline void emit(uintptr_t x, RelocInfo::Mode
rmode);
On 2013/07/23 12:40:54, danno wrote:
> why not call this emitp (i.e. for "pointer") and have it take a void*
parameter?
> I think that makes it clearer. Then some of the reinterpret_cast nastiness can
> be hidden and centralized inside emitp.

Done.

[danno, 2013-07-24 13:14:29]

lgtm

[haitao.feng, 2013-07-24 13:51:01]

Committed patchset #2 manually as r15861 (presubmit successful).