Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1522)

Issue 19752004: Add the emitp function for X64 assembler (Closed)

Created:
7 years, 5 months ago by haitao.feng
Modified:
7 years, 5 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Add the emitp function for X64 assembler R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15861

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M src/x64/assembler-x64.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
haitao.feng
This is danno's comment on https://codereview.chromium.org/18014003.
7 years, 5 months ago (2013-07-18 13:15:58 UTC) #1
danno
https://codereview.chromium.org/19752004/diff/1/src/x64/assembler-x64.h File src/x64/assembler-x64.h (left): https://codereview.chromium.org/19752004/diff/1/src/x64/assembler-x64.h#oldcode1447 src/x64/assembler-x64.h:1447: inline void emitq(uint64_t x, RelocInfo::Mode rmode); I don't see ...
7 years, 5 months ago (2013-07-23 12:40:54 UTC) #2
haitao.feng
danno, thanks for the review. https://codereview.chromium.org/19752004/diff/1/src/x64/assembler-x64.h File src/x64/assembler-x64.h (left): https://codereview.chromium.org/19752004/diff/1/src/x64/assembler-x64.h#oldcode1447 src/x64/assembler-x64.h:1447: inline void emitq(uint64_t x, ...
7 years, 5 months ago (2013-07-24 06:35:12 UTC) #3
danno
lgtm
7 years, 5 months ago (2013-07-24 13:14:29 UTC) #4
haitao.feng
7 years, 5 months ago (2013-07-24 13:51:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r15861 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698